You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/23 23:40:00 UTC

[GitHub] srkukarni commented on a change in pull request #2826: Secrets Interface

srkukarni commented on a change in pull request #2826: Secrets Interface
URL: https://github.com/apache/pulsar/pull/2826#discussion_r227601526
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/io/SinkConfig.java
 ##########
 @@ -55,6 +55,7 @@
     private Map<String, ConsumerConfig> inputSpecs = new TreeMap<>();
 
     private Map<String, Object> configs;
+    private Map<String, String> secrets;
 
 Review comment:
   Isn't this already two levels. SecretName and SecretPath?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services