You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/02 23:32:06 UTC

[kudu-CR] fs: clarify failures on non-disk-failures

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9717 )

Change subject: fs: clarify failures on non-disk-failures
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9717/2/src/kudu/tablet/tablet_replica_mm_ops.cc
File src/kudu/tablet/tablet_replica_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/9717/2/src/kudu/tablet/tablet_replica_mm_ops.cc@145
PS2, Line 145: Flush MRS failure is not supported
I think this is still unclear to a user. "not supported" makes it sound like they tried to do something which Kudu doesn't support.

Really the error is "Cannot recover from error during flush of MRS: " or somesuch, right? Or "Unrecoverable flush error: "



-- 
To view, visit http://gerrit.cloudera.org:8080/9717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I062bbb69847f7da5d381281a6c24b806bafc2620
Gerrit-Change-Number: 9717
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 23:32:06 +0000
Gerrit-HasComments: Yes