You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/05 22:32:21 UTC

[GitHub] [arrow] terencehonles commented on a change in pull request #9103: ARROW-11132: [CI] Use pip to install crossbow's dependencies for the comment bot

terencehonles commented on a change in pull request #9103:
URL: https://github.com/apache/arrow/pull/9103#discussion_r552238594



##########
File path: dev/archery/setup.py
##########
@@ -26,7 +26,9 @@
 
 extras = {
     'benchmark': ['pandas'],
-    'bot': ['ruamel.yaml', 'pygithub'],
+    # bot extra includes crossbow's dependencies

Review comment:
       Might it make sense to separate crossbow's dependencies and specify the install as `arrow/dev/archery[bot,crossbow]`?
   
   That way you could install the dependencies with one of the other extras. This is partially because I'm not sure if I should use `arrow/dev/archery[bot]` for what I'm copying in #8915 from https://github.com/apache/arrow/commit/7f11abee01104fceb47088ea42501935a44b0b36#diff-90e4e8bfd9b23a7b4bf4cfa1cb4bd0d80a87e21ac7fbd3a39c30f19709d4c705R50-R61




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org