You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2025/05/19 19:54:30 UTC

[kudu-CR] KUDU-3663: Support certificates signed with RSASSA-PSS for channel bindings

Hello Alexey Serbin, Jason Fehr, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22910

to look at the new patch set (#3).

Change subject: KUDU-3663: Support certificates signed with RSASSA-PSS for channel bindings
......................................................................

KUDU-3663: Support certificates signed with RSASSA-PSS for channel bindings

The existing code to determine the hash algorithm for a certificate
does not handle RSASSA-PSS signatures as the hash algorithm is
configurable for RSASSA-PSS. OpenSSL 1.1.1 introduced the
x509_get_signature_info() function, which is able to determine the
hash algorithm even for RSASSA-PSS. This uses x509_get_signature_info()
whenever building against OpenSSL 1.1.1 or above. This is similar to
the fix used in Postgres when faced with the same issue.

Testing:
 - Added a test certificate that uses RSASSA-PSS and a test case in
   cert-test to verify that it can determine the hash algorithm used

Change-Id: I26a25a43d778fd2f2fcf293ecb199133c675212b
---
M src/kudu/security/cert-test.cc
M src/kudu/security/cert.cc
M src/kudu/security/cert.h
M src/kudu/security/test/test_certs.cc
M src/kudu/security/test/test_certs.h
5 files changed, 132 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/22910/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26a25a43d778fd2f2fcf293ecb199133c675212b
Gerrit-Change-Number: 22910
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)