You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tvm.apache.org by Junru Shao <no...@github.com.INVALID> on 2021/06/08 20:26:05 UTC
[apache/tvm-rfcs] [RFC] Meta Schedule (AutoTensorIR) (#5)
You can view, comment on, or merge this pull request online at:
https://github.com/apache/tvm-rfcs/pull/5
-- Commit Summary --
* [RFC] Meta Schedule (AutoTensorIR)
-- File Changes --
A rfcs/0001-meta-schedule-autotensorir.md (297)
-- Patch Links --
https://github.com/apache/tvm-rfcs/pull/5.patch
https://github.com/apache/tvm-rfcs/pull/5.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Junru Shao <no...@github.com.INVALID>.
@tkonolige thanks for the review!
> The biggest one I can think of is the fact that we will have to rewrite all our existing schedules to take advantage of the new infrastructure.
Given in most of the time we use sketch generation (in Ansor's terminology) to generate schedules automatically, we can just remove most of the schedules written in TE. Alternatively, we do need to rewrite all of the Ansor's sketch rules, including (defined in `src/auto_scheduler/search_policy/sketch_policy_rules.h`):
- Always-Inline
- Multi-Level-Tiling
- Multi-Level-Tiling-with-Fusion
- Add-Cache-Read
- Add-Cache-Write
- Add-RFactor
- Simplify-Compute-with-Const-Tensor
- Cross-Thread-Reduction
- Special-Compute-Location
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-875121662
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Tianqi Chen <no...@github.com.INVALID>.
@FrozenGene @comaniac @tkonolige please take another look
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-872245721
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Tianqi Chen <no...@github.com.INVALID>.
@areusch @junrushao1994 do you mind follow up a bit on this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-884512750
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Junru Shao <no...@github.com.INVALID>.
Sorry for the late reply! I will be working on it today
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-886889157
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Tianqi Chen <no...@github.com.INVALID>.
Thanks everyone. This RFC is now accepted. Assigning RFC number 0001
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-887115326
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Junru Shao <no...@github.com.INVALID>.
@areusch Thank you sooo much for reviewing this RFC! I really appreciate it that you went over the text very carefully and provided very helpful suggestions! Just finished a pass revising the RFC. Would you like to take another look? Thanks a lot!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-878885449
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Tianqi Chen <no...@github.com.INVALID>.
Merged #5 into main.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#event-5071347812
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Junru Shao <no...@github.com.INVALID>.
CC: @jroesch @icemelon9 @kparzysz-quic @FrozenGene @jcf94
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-857460287
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Junru Shao <no...@github.com.INVALID>.
Updated according to the comments. Would you guys like to re-review? @tqchen
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-871760591
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Tianqi Chen <no...@github.com.INVALID>.
Thanks everyone. It would be great to work to land this RFC :) @junrushao1994 please try your best attempt to address the latest batch of comments from @areusch and then i think we can merge this in
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-886048659
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Junru Shao <no...@github.com.INVALID>.
@tkonolige @comaniac I updated with some explanation that we replay the trace repetitively to do random search, and some examples of trace-based analysis. Would you guys like to take another look? Thanks a lot!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-875137200
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Junru Shao <no...@github.com.INVALID>.
@areusch @tqchen Thanks for your time reviewing the RFC! Just addressed all the comments and please take another look when you guys got time :-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-887082344
Re: [apache/tvm-rfcs] [RFC] Meta Schedule (AutoTIR) (#5)
Posted by Junru Shao <no...@github.com.INVALID>.
Sorry for the delay! I am getting back on this RFC and will be working on it in the rest of this week
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/5#issuecomment-871602430