You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by haucke <gi...@git.apache.org> on 2016/10/30 14:32:18 UTC

[GitHub] libcloud pull request #930: 0.20.1

GitHub user haucke opened a pull request:

    https://github.com/apache/libcloud/pull/930

    0.20.1

    ## PEP8 Guidelines
    
    ### PEP 8 Guidelines not followed. Code must be changed to allot for guidelines.
    
    -<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
    -<response requestId="na/2014-04-14T13:37:20/62f06368-c3fb-11e3-b29c-001517c4643e" xmlns="urn:didata.com:api:cloud:types">
    -<operation>ADD_PUBLIC_IP_BLOCK</operation>
    -<responseCode>OK</responseCode>
    -<message>Public IPv4 Address Block has been added successfully to Network Domain.</message>
    -<info name="publicIpBlockId" value="4487241a-f0ca-11e3-9315-d4bed9b167ba"/>
    +<?xml version="1.0" encoding="UTF-8"?>
    +<response xmlns="urn:didata.com:api:cloud:types" requestId="na/2015-12-20T16:59:48.842-05:00/28d362bb-249c-42b6-9236-ddd8729f332c">
    +    <operation>ADD_PUBLIC_IP_BLOCK</operation>
    +    <responseCode>OK</responseCode>
    +    <message>Public IPv4 Address Block has been added successfully to Network Domain d3320077-c2ce-4523-8c65-d417e766077b.</message>
    +    <info name="ipBlockId" value="4487241a-f0ca-11e3-9315-d4bed9b167ba"/>
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/libcloud 0.20.1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #930
    
----
commit 38b61eb13fcee91c1a172516da93a9c652b29024
Author: Greg Hill <gr...@rackspace.com>
Date:   2015-12-15T16:42:47Z

    Use hasattr rather than getattr to check for existence
    
    I forgot getattr throws an exception.  This should have
    been a hasattr.  Additionally added a check to make sure
    it's a dict before treating it as such.
    Closes #659

commit 1b3b91cd0e96161b059c15ad2da183f500c3878e
Author: Juan Font Alonso <ju...@gmail.com>
Date:   2015-12-10T13:44:43Z

    Fixed error when proxy_url is None.

commit eb49f38dfa21887774d24d0cd1079c1958ea8a7e
Author: anthony-shaw <an...@gmail.com>
Date:   2015-12-20T22:05:16Z

    Fixed bug in public IP addition command
    
    Closes #661

commit 302b9bba33aeecbc2768c9d796845d31a2a1e9e4
Author: Ming Sheng <mi...@gmail.com>
Date:   2015-12-20T15:02:12Z

    Fix syntax error for DimensionDataStatus object
    
    Closes #662

commit 22093a6a55a73274be263567effbe1af577e22c7
Author: Eric Johnson <er...@google.com>
Date:   2015-12-18T23:57:47Z

    [google] Allow for old and new style service account client email address
    
    Closes LIBCLOUD-785

commit d1cf931796f1064f5b1c36d35a80551488fb5d50
Author: Eric Johnson <er...@google.com>
Date:   2016-01-15T15:39:46Z

    bugfix version 0.20.1

commit 87deb04498ea8bb5068e362810c3d2ab89359b48
Author: Eric Johnson <er...@google.com>
Date:   2016-01-15T19:28:44Z

    update chnages for 0.20.1

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #930: 0.20.1

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/930


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---