[GitHub] [flink] zentol commented on a change in pull request #9113: [FLINK-13222] [runtime] Add documentation for failover strategy option

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #9113: [FLINK-13222] [runtime] Add documentation for failover strategy option
URL: https://github.com/apache/flink/pull/9113#discussion_r303816275
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
 ##########
 @@ -106,17 +106,21 @@
 	/**
 	 * This option specifies the failover strategy, i.e. how the job computation recovers from task failures.
 	 */
-	@Documentation.ExcludeFromDocumentation("The failover strategy feature is highly experimental.")
 	public static final ConfigOption<String> EXECUTION_FAILOVER_STRATEGY =
 		key("jobmanager.execution.failover-strategy")
 			.defaultValue("full")
 			.withDescription(Description.builder()
-				.text("This option specifies how the job computation recovers from task failures. " +
+				.text("This option specifies the failover strategy, i.e. " +
+					"how the job computation recovers from task failures. " +
 					"Accepted values are:")
 				.list(
-					text("'full': Restarts all tasks."),
-					text("'individual': Restarts only the failed task. Should only be used if all tasks are independent components."),
-					text("'region': Restarts all tasks that could be affected by the task failure.")
+					text("'full': Use RestartAllStrategy to restarts all tasks to recover the job."),
+					text("'region': Use AdaptedRestartPipelinedRegionStrategyNG to restart all tasks " +
 
 Review comment:
   From a users perspective restart and failover strategies are connected quite closely, with one defining the "how" and the other defining "how often".
   From a technical perspective they also aren't independent, since if restarts are disabled the failover strategy will not kick in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services