You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/16 06:10:14 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new issue #4773:
CuratorZookeeperClient change-event bug in Unit Test
kimmking opened a new issue #4773: CuratorZookeeperClient change-event bug in Unit Test
URL: https://github.com/apache/incubator-shardingsphere/issues/4773
Generally the Unittests will be successful. But sometimes Unittests failed with an error:
```
[ERROR] Tests run: 12, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.731 s <<< FAILURE! - in org.apache.shardingsphere.orchestration.center.instance.CuratorZookeeperCenterRepositoryTest
[ERROR] assertWatchDeletedChangedType(org.apache.shardingsphere.orchestration.center.instance.CuratorZookeeperCenterRepositoryTest) Time elapsed: 4.995 s <<< ERROR!
java.util.concurrent.TimeoutException: Timeout waiting for task.
at org.apache.shardingsphere.orchestration.center.instance.CuratorZookeeperCenterRepositoryTest.assertWatchDeletedChangedType(CuratorZookeeperCenterRepositoryTest.java:105)
```
The details see:
https://api.travis-ci.org/v3/job/661777933/log.txt
and the main part of logs: [zk-change.txt](https://github.com/apache/incubator-shardingsphere/files/4336263/zk-change.txt)
This test case use curator testingzkserver and cache to support zk unit test, and then watch a key to fire a delete event.
After comparing with a normal log and an error log.
We find a normal one:
> publish and process a delete event with key `/test/children/5`
And an error one:
> only pushlish a NodeChangeEvent with the parent key `/test/children`, which watched by the last case
So, now we can't reproduce this error by sevaral times running.
But we would like to fix it now and make some further investigation about it：
- [ ] set an independent key for each watched test case to avoid only publishing parent event
- [ ] test the bug is related of zk-server or curator+cache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4773:
CuratorZookeeperClient change-event bug in Unit Test
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4773: CuratorZookeeperClient change-event bug in Unit Test
URL: https://github.com/apache/incubator-shardingsphere/issues/4773#issuecomment-602348617
## 20200323
After this issue occurs again in 3.20, we found the "curator client"(clientA) in unit test case was not the same of CenterRepository "client"(clientB).
When the test class initialized, a testingserver(serverA) started and clientA is connecting to serverA.
And then in serveral test cases, testingserver renewed to severB，serverC&severD，with clientB changed to clientC, clientD, ClientE, not the origin serverA&clientB.
So，we modify(#4894)：
- [x] 1、Remove testserver renewing and keep only one server during this test class running
- [x] 2、Use final CenterRepository "client" instead of clientA， keep only one client
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4773:
CuratorZookeeperClient change-event bug in Unit Test
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #4773: CuratorZookeeperClient change-event bug in Unit Test
URL: https://github.com/apache/incubator-shardingsphere/issues/4773
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services