You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org> on 2017/07/19 17:03:52 UTC
Change in asterixdb[master]: ResultWriterOperatorDescriptor fail() NPE on open() failure
Michael Blow has submitted this change and it was merged.
Change subject: ResultWriterOperatorDescriptor fail() NPE on open() failure
......................................................................
ResultWriterOperatorDescriptor fail() NPE on open() failure
Conform to IFrameWriter contract for fail()
Change-Id: I613dcae32596af43476cf61d0245bfed258359de
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1834
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
BAD: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <ti...@apache.org>
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/result/ResultWriterOperatorDescriptor.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; No violations found; Verified
diff --git a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/result/ResultWriterOperatorDescriptor.java b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/result/ResultWriterOperatorDescriptor.java
index 78417ac..58eee79 100644
--- a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/result/ResultWriterOperatorDescriptor.java
+++ b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/result/ResultWriterOperatorDescriptor.java
@@ -112,7 +112,9 @@
@Override
public void fail() throws HyracksDataException {
failed = true;
- datasetPartitionWriter.fail();
+ if (datasetPartitionWriter != null) {
+ datasetPartitionWriter.fail();
+ }
}
@Override
--
To view, visit https://asterix-gerrit.ics.uci.edu/1834
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I613dcae32596af43476cf61d0245bfed258359de
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>