You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jochen Wiedmann <jo...@gmail.com> on 2007/02/14 05:56:17 UTC
[VOTE] Release commons-fileupload 1.2 (4th attempt)
Hi,
this is going to kill me, but I'd like to call for a release of
commons-fileupload 1.2 once more. Commons-fileupload-1.2rc4 is
available from
http://people.apache.org/~jochen/commons-fileupload/dist
The generated site is at
http://people.apache.org/~jochen/commons-fileupload/dist
The SVN tag is
commons-fileupload-1.2rc4
Compared to rc3, the following things have been changed:
* The LICENSE.txt and NOTICE.txt files are now added to all jar files.
(They had been added before, but been overwritten when the assemblies
have been created.)
* A workaround for a bug in the maven-site-plugin has been added.
This bug prevented static resources being added. In particular, the
logo of the commons-fileupload project was missing.
* The RAT report is now added to the projects reports.
* The clirr report is now also added to the project reports. (No idea
why this wasn't the case before.)
Thanks,
Jochen
[ ] +1
[ ] =0
[ ] -1
--
How fast can a year go? As fast as your childs first year.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Jörg Schaible <jo...@gmx.de>.
Stephen Colebourne wrote:
> Jochen Wiedmann wrote:
>> On 2/16/07, Jörg Schaible <jo...@gmx.de> wrote:
>>
>>> > (1) The md5 files do not contain the file name, which is standard for
>>> > commons components (see section 2 of [1]).
>>>
>>> This is the way Maven 2 generates *and* checks it. So if you change
>>> those, I
>>> am quite sure, that every M2 user will get always a warning because of
>>> the
>>> checksum!
>>
>> I believe that Olivers and your concerms can be resolved by proposing
>> that the files that go into /www/www.apache.org/dist are distributed
>> as proposed by Oliver. OTOH, the files that go into the Maven
>> repository won't have a file name.
>
> See commons-io in the maven2 repository:
>
http://mirrors.ibiblio.org/pub/mirrors/maven2/commons-io/commons-io/1.3/commons-io-1.3.jar.md5
>
> The *filename part is present.
>
> Does it cause any issues? I don't know, I don't use maven 2. I doubt it
> though as no ones ever complained.
Well, I said *if* any user gets a warning I am -1 to such a change. Honestly
I don't know either, but M2 is not the only software anymore accessing the
public repos. Interfering in the way the deploy plugin works is at current
stage a major hassle and IMHO not worth to prevent a release. If we wanna
have such a change, we have to change the way the plugin works.
- Jörg
- Jörg
>
> Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Stephen Colebourne <sc...@btopenworld.com>.
Jochen Wiedmann wrote:
> On 2/16/07, Jörg Schaible <jo...@gmx.de> wrote:
>
>> > (1) The md5 files do not contain the file name, which is standard for
>> > commons components (see section 2 of [1]).
>>
>> This is the way Maven 2 generates *and* checks it. So if you change
>> those, I
>> am quite sure, that every M2 user will get always a warning because of
>> the
>> checksum!
>
> I believe that Olivers and your concerms can be resolved by proposing
> that the files that go into /www/www.apache.org/dist are distributed
> as proposed by Oliver. OTOH, the files that go into the Maven
> repository won't have a file name.
See commons-io in the maven2 repository:
http://mirrors.ibiblio.org/pub/mirrors/maven2/commons-io/commons-io/1.3/commons-io-1.3.jar.md5
The *filename part is present.
Does it cause any issues? I don't know, I don't use maven 2. I doubt it
though as no ones ever complained.
Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Jochen Wiedmann <jo...@gmail.com>.
On 2/16/07, Jörg Schaible <jo...@gmx.de> wrote:
> > (1) The md5 files do not contain the file name, which is standard for
> > commons components (see section 2 of [1]).
>
> This is the way Maven 2 generates *and* checks it. So if you change those, I
> am quite sure, that every M2 user will get always a warning because of the
> checksum!
I believe that Olivers and your concerms can be resolved by proposing
that the files that go into /www/www.apache.org/dist are distributed
as proposed by Oliver. OTOH, the files that go into the Maven
repository won't have a file name.
Jochen
--
Emacs 22 will support MacOS and CygWin. It is not yet decided, whether
these will be used to run Emacs or the other way round.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Jörg Schaible <jo...@gmx.de>.
Oliver Heger wrote:
> Two minor points:
>
> (1) The md5 files do not contain the file name, which is standard for
> commons components (see section 2 of [1]).
This is the way Maven 2 generates *and* checks it. So if you change those, I
am quite sure, that every M2 user will get always a warning because of the
checksum!
[snip]
> (2) In the jar generated by the ant build the LICENSE is missing.
>
> (2) is probably less important for components that use maven as
> preferred build tool. I am not sure how important (1) is.
>
> Otherwise everything looks good. So I am +1 when (1) is fixed.
If every user gets a warning when this is fixed, I am -1 on this fix :D
[snip]
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Oliver Heger <ol...@oliver-heger.de>.
Two minor points:
(1) The md5 files do not contain the file name, which is standard for
commons components (see section 2 of [1]).
(2) In the jar generated by the ant build the LICENSE is missing.
(2) is probably less important for components that use maven as
preferred build tool. I am not sure how important (1) is.
Otherwise everything looks good. So I am +1 when (1) is fixed.
Oliver
[1] http://jakarta.apache.org/commons/releases/release.html
Jochen Wiedmann wrote:
> Hi,
>
> this is going to kill me, but I'd like to call for a release of
> commons-fileupload 1.2 once more. Commons-fileupload-1.2rc4 is
> available from
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The generated site is at
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The SVN tag is
>
> commons-fileupload-1.2rc4
>
> Compared to rc3, the following things have been changed:
>
> * The LICENSE.txt and NOTICE.txt files are now added to all jar files.
> (They had been added before, but been overwritten when the assemblies
> have been created.)
> * A workaround for a bug in the maven-site-plugin has been added.
> This bug prevented static resources being added. In particular, the
> logo of the commons-fileupload project was missing.
> * The RAT report is now added to the projects reports.
> * The clirr report is now also added to the project reports. (No idea
> why this wasn't the case before.)
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Niall Pemberton <ni...@gmail.com>.
On 2/14/07, Jochen Wiedmann <jo...@gmail.com> wrote:
>
> [X] +1
> [ ] =0
> [ ] -1
I do have a few comments on the site/docs - none of which IMO should
prevent the release - and my +1 vote is unconditional.
There are a couple of maven2 issues with the site generation which
makes me think that it might be better to exclude the site from the
distro (just including the JavaDocs):
- Links are being converted to relative ones, so for example the
Commons & Jakarta links don't work for the site/docs included in the
distro.
- The changes report for m2 doesn't like html markup and entries that
have it appear as blank. For fileupload there are a few such blank
entries in the previous releases section.
I can understand you wanting to get the release out and not wait for
the next Commons POM release - it does mean that the site/docs don't
have the standard Commons L&F and perhaps another reason for excluding
them - but as long as that isn't whats published as the FileUpload web
site, thats the main thing.
Niall
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Henri Yandell <fl...@gmail.com>.
On 2/13/07, Jochen Wiedmann <jo...@gmail.com> wrote:
> [X] +1
> [ ] =0
> [ ] -1
Site:
* Date obviously needs to be fixed on front page of website once the
release goes out.
* It'd be useful if the Streaming API page mentions that it arrived in 1.2.
* Linking to http://jakarta.apache.org/site/downloads/downloads_commons-fileupload.cgi
on the lhs navbar would be good.
None are blocking (as they can be fixed after the fact).
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Jörg Schaible <jo...@gmx.de>.
+1
building from source in Gentoo Linux with Maven 1, all tests pass for all my
JDK's (1.3.1 to 1.6 from various vendors).
- Jörg
Jochen Wiedmann wrote:
> Hi,
>
> this is going to kill me, but I'd like to call for a release of
> commons-fileupload 1.2 once more. Commons-fileupload-1.2rc4 is
> available from
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The generated site is at
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The SVN tag is
>
> commons-fileupload-1.2rc4
>
> Compared to rc3, the following things have been changed:
>
> * The LICENSE.txt and NOTICE.txt files are now added to all jar files.
> (They had been added before, but been overwritten when the assemblies
> have been created.)
> * A workaround for a bug in the maven-site-plugin has been added.
> This bug prevented static resources being added. In particular, the
> logo of the commons-fileupload project was missing.
> * The RAT report is now added to the projects reports.
> * The clirr report is now also added to the project reports. (No idea
> why this wasn't the case before.)
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Davanum Srinivas <da...@gmail.com>.
+1
On 2/13/07, Jochen Wiedmann <jo...@gmail.com> wrote:
> Hi,
>
> this is going to kill me, but I'd like to call for a release of
> commons-fileupload 1.2 once more. Commons-fileupload-1.2rc4 is
> available from
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The generated site is at
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The SVN tag is
>
> commons-fileupload-1.2rc4
>
> Compared to rc3, the following things have been changed:
>
> * The LICENSE.txt and NOTICE.txt files are now added to all jar files.
> (They had been added before, but been overwritten when the assemblies
> have been created.)
> * A workaround for a bug in the maven-site-plugin has been added.
> This bug prevented static resources being added. In particular, the
> logo of the commons-fileupload project was missing.
> * The RAT report is now added to the projects reports.
> * The clirr report is now also added to the project reports. (No idea
> why this wasn't the case before.)
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
> --
> How fast can a year go? As fast as your childs first year.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
--
Davanum Srinivas :: http://wso2.org/ :: Oxygen for Web Services Developers
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release commons-fileupload 1.2 (4th attempt)
Posted by Lennard Fuller <lf...@unicon.net>.
+1
Jochen Wiedmann wrote:
> Hi,
>
> this is going to kill me, but I'd like to call for a release of
> commons-fileupload 1.2 once more. Commons-fileupload-1.2rc4 is
> available from
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The generated site is at
>
> http://people.apache.org/~jochen/commons-fileupload/dist
>
> The SVN tag is
>
> commons-fileupload-1.2rc4
>
> Compared to rc3, the following things have been changed:
>
> * The LICENSE.txt and NOTICE.txt files are now added to all jar files.
> (They had been added before, but been overwritten when the assemblies
> have been created.)
> * A workaround for a bug in the maven-site-plugin has been added.
> This bug prevented static resources being added. In particular, the
> logo of the commons-fileupload project was missing.
> * The RAT report is now added to the projects reports.
> * The clirr report is now also added to the project reports. (No idea
> why this wasn't the case before.)
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org