You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/22 23:30:40 UTC
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull
request #15593: Large Index Support for Slice
access2rohit commented on a change in pull request #15593: Large Index Support for Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306074443
##########
File path: src/operator/tensor/matrix_op-inl.h
##########
@@ -1323,12 +1323,12 @@ inline bool SliceLikeShape(const nnvm::NodeAttrs& attrs,
inline void SliceLikeInferRanges(const mxnet::TShape& dshape,
const mxnet::TShape& fshape,
const mxnet::Tuple<int>& axes,
- mxnet::Tuple<dmlc::optional<int>>* param_begin,
- mxnet::Tuple<dmlc::optional<int>>* param_end,
- mxnet::Tuple<dmlc::optional<int>>* param_step) {
- std::vector<dmlc::optional<int>> pb(dshape.ndim());
- std::vector<dmlc::optional<int>> pe(dshape.ndim());
- std::vector<dmlc::optional<int>> ps(dshape.ndim());
+ mxnet::Tuple<dmlc::optional<index_t>>* param_begin,
+ mxnet::Tuple<dmlc::optional<index_t>>* param_end,
+ mxnet::Tuple<dmlc::optional<index_t>>* param_step) {
+ std::vector<dmlc::optional<index_t>> pb(dshape.ndim());
+ std::vector<dmlc::optional<index_t>> pe(dshape.ndim());
+ std::vector<dmlc::optional<index_t>> ps(dshape.ndim());
if (axes.ndim() == 0) {
for (int i = 0; i < dshape.ndim(); ++i) {
Review comment:
param_begin and param_end can be -1 hence we require signed integer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services