[jira] [Comment Edited] (MESOS-6184) Health checks should use a general mechanism to enter namespaces of the task.

["haosdent (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600120#comment-15600120 ] 

haosdent edited comment on MESOS-6184 at 11/27/16 10:50 AM:
------------------------------------------------------------

| Used child hooks to enter namespaces in health check.
 | https://reviews.apache.org/r/53122/ |
| Made `process::defaultClone` private. | https://reviews.apache.org/r/53123 |


was (Author: haosdent@gmail.com):
Patch: https://reviews.apache.org/r/53122/

> Health checks should use a general mechanism to enter namespaces of the task.
> -----------------------------------------------------------------------------
>
>                 Key: MESOS-6184
>                 URL: https://issues.apache.org/jira/browse/MESOS-6184
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: haosdent
>            Assignee: haosdent
>            Priority: Blocker
>              Labels: health-check, mesosphere
>
> To perform health checks for tasks, we need to enter the corresponding namespaces of the container. For now health check use custom clone to implement this
> {code}
>   return process::defaultClone([=]() -> int {
>     if (taskPid.isSome()) {
>       foreach (const string& ns, namespaces) {
>         Try<Nothing> setns = ns::setns(taskPid.get(), ns);
>         if (setns.isError()) {
>           ...
>         }
>       }
>     }
>     return func();
>   });
> {code}
> After the childHooks patches merged, we could change the health check to use childHooks to call {{setns}} and make {{process::defaultClone}} private again.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)