[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #1200: remove reflect in grpc server

[GitBox <gi...@apache.org>]

gaoxinge commented on a change in pull request #1200:
URL: https://github.com/apache/dubbo-go/pull/1200#discussion_r642005712



##########
File path: protocol/grpc/server.go
##########
@@ -134,18 +136,12 @@ func waitGrpcExporter(providerServices map[string]*config.ServiceConfig) {
 func registerService(providerServices map[string]*config.ServiceConfig, server *grpc.Server) {
 	for key, providerService := range providerServices {
 		service := config.GetProviderService(key)
-
 		ds, ok := service.(DubboGrpcService)
 		if !ok {

Review comment:
       `service` check exist: https://github.com/apache/dubbo-go/blob/master/config/config_loader.go#L259-L264.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org