[GitHub] [ignite] x-kreator commented on a change in pull request #7004: IGNITE-1606 NPE during node stop due to nullified logger in TcpCommunicationSpi

[GitBox <gi...@apache.org>]

x-kreator commented on a change in pull request #7004: IGNITE-1606 NPE during node stop due to nullified logger in TcpCommunicationSpi
URL: https://github.com/apache/ignite/pull/7004#discussion_r338949004
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/resource/GridResourceIoc.java
 ##########
 @@ -574,6 +574,16 @@ public boolean inject(Object target,
             ResourceAnnotation.IGNITE_INSTANCE,
             ResourceAnnotation.LOGGER,
             ResourceAnnotation.SERVICE
+        ),
+
+        /**
+         * Same as {@link #GENERIC} excluding {@link ResourceAnnotation#LOGGER}.
+         */
+        GENERIC_CLEANABLE(
 
 Review comment:
   Is it right that you suggest to add a new AnnotationSet.LOGGER with ResourceAnnotation.LOGGER only and use it at the points where AnnotationSet.GENERIC is injecting but don't use one at cleanup?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services