You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/04/06 11:10:01 UTC

[GitHub] [tomcat] be-hase opened a new pull request, #493: Do not use legacy character encoding(Shift_JIS) as default

be-hase opened a new pull request, #493:
URL: https://github.com/apache/tomcat/pull/493

   ## Motivation
   
   With this commit, `Shift_JIS` is now used as the default for `jp`.
   eda77cd88b84d6002d9efb818e6d3fbc241e2284
   
   `Shift_JIS` is a legacy character code, and this change causes a bug in the behavior of the application at Japan.
   
   For example, Spring Boot has the following support due to this commit.
   https://github.com/spring-projects/spring-boot/pull/30535
   However, I think it is better to revert the commit on the tomcat side as well.
   
   ## What
   
   Revert eda77cd88b84d6002d9efb818e6d3fbc241e2284
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] be-hase commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

Posted by GitBox <gi...@apache.org>.
be-hase commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1091012924

   [off topic]
   For [Spring4Shell](https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement), I did a version up of Spring Boot. Then I met this `Shift_JIS` problem. 😭 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] markt-asf commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

Posted by GitBox <gi...@apache.org>.
markt-asf commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1112523717

   I am going to revert this change but simply reverting the commit also reverts the changelog which I don't want. I'll do a manual revert. The TCK issue can be addressed via configuration in the global web.xml. I'm closing this PR as I need to do a manual revert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] be-hase commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

Posted by GitBox <gi...@apache.org>.
be-hase commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1090173899

   Sorry, I'm not familiar with full history. I would be grateful if you could consider this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] markt-asf commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

Posted by GitBox <gi...@apache.org>.
markt-asf commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1090159236

   This needs careful thought as the mapping was added to address a TCK failure. We need to look into the full history to figure out the right fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] markt-asf closed pull request #493: Do not use legacy character encoding(Shift_JIS) as default

Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #493: Do not use legacy character encoding(Shift_JIS) as default
URL: https://github.com/apache/tomcat/pull/493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] be-hase commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

Posted by GitBox <gi...@apache.org>.
be-hase commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1124475153

   Thanks your handling :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org