You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/06/02 07:40:14 UTC
Re: Review Request 30267: SENTRY-621: Add new thrift interface for
import/export in sentry
> On May 11, 2015, 6:13 p.m., Prasad Mujumdar wrote:
> > Couple of high level questions/comments
> > - Will it handle the generalized schema privilegs as well ?
> > - It might be a good idea to include the product and schema version of the metadata being imported/exported. It would be helpful in maintaining backward compatibility in future releases.
thanks for the comments, for point1, I want to create a new JIRA to track this.
for point2, I think schema version of the metadata shouldn't be imported and overwrite the current data, it should be used for the version check. currently, this will not a big problem, and I also want to create another JIRA to track this.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30267/#review83252
-----------------------------------------------------------
On May 20, 2015, 1:43 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30267/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 1:43 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add new thrift interface for import/export in sentry
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java c47f64a
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataResponse.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataRequest.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataResponse.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryMappingData.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 993ea46
>
> Diff: https://reviews.apache.org/r/30267/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>