You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/03/08 13:32:43 UTC

[jira] [Commented] (SLING-3443) Parameter based redirection vulnerability in FormAuthenticationHandler

    [ https://issues.apache.org/jira/browse/SLING-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924823#comment-13924823 ] 

ASF GitHub Bot commented on SLING-3443:
---------------------------------------

GitHub user bond- opened a pull request:

    https://github.com/apache/sling/pull/12

    SLING-3443: Parameter based redirection vulnerability in FormAuthenticationHandler

    *FormAuthenticationHandler* didn't url encode the parameter(*Authenticator.LOGIN_RESOURCE*) before redirection. This leads the attacker to use this parameter to redirect to a different domain. This may also help in phishing attacks. 
    
    This was initially spotted in one of our applications which use org.apache.sling:org.apache.sling.auth.form:1.0.2
    
    This pull request fixes the vulnerability.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bond-/sling sling-3443

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit d1531735762e7423404f1e304dfc4c483f9556de
Author: Raviteja Lokineni <ra...@gmail.com>
Date:   2014-03-08T12:24:52Z

    SLING-3443: Parameter based redirection vulnerability in FormAuthenticationHandler

----


> Parameter based redirection vulnerability in FormAuthenticationHandler
> ----------------------------------------------------------------------
>
>                 Key: SLING-3443
>                 URL: https://issues.apache.org/jira/browse/SLING-3443
>             Project: Sling
>          Issue Type: Bug
>          Components: Authentication
>    Affects Versions: Form Based Authentication 1.0.2
>            Reporter: Ravi Teja
>            Priority: Critical
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Suppose your login url is: http://blah/blah?resource=http://www.google.com
> Then after login succeeds, user would be redirected to http://www.google.com
> Will be submitting a pull request for this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)