[RESULT] Release Apache Parquet 1.12.0 RC3

[Gabor Szadovszky <ga...@cloudera.com.INVALID>]

I don't agree. This is a regression where existing code might fail with the
new release. Even though it is easy to fix from the client side we shall
provide backward compatibility. I'm giving a -1(binding). This vote is
FAILED.

Created PARQUET-1999 <https://issues.apache.org/jira/browse/PARQUET-1999> to
track this issue.

On Mon, Mar 15, 2021 at 5:10 PM Xinli shang <sh...@uber.com.invalid> wrote:

> Thanks DB! In that case, I would like to change my vote to +1.
>
> On Sat, Mar 13, 2021 at 11:14 PM DB Tsai <db...@apache.org> wrote:
>
> > This can be a couple lines fix in Iceberg side which we had and deployed
> > in our env, so it is not necessary to fail this vote.
> >
> > On 2021/03/13 01:03:04 Xinli shang wrote:
> > > I vote -1.
> > >
> > > I downloaded and built it fine, but when I tested it in Iceberg, I saw
> a
> > > lot of test failed as below. This is related to Parquet-1970
> > > <
> >
> https://github.com/apache/parquet-mr/pull/861/commits/16fa8ccd7af0312c337e178381c380d66c83a915
> > >
> > > .
> > >
> > > org.apache.iceberg.parquet.TestDictionaryRowGroupFilter > testAllNulls
> > > FAILED
> > >
> > >     java.lang.IllegalArgumentException: Can not create a Path from a
> null
> > > string
> > >
> > >         at org.apache.hadoop.fs.Path.checkPathArg(Path.java:122)
> > >
> > >         at org.apache.hadoop.fs.Path.<init>(Path.java:134)
> > >
> > >         at
> > > org.apache.parquet.hadoop.ParquetWriter.<init>(ParquetWriter.java:285)
> > >
> > >         at
> > >
> >
> org.apache.parquet.hadoop.ParquetWriter$Builder.build(ParquetWriter.java:640)
> > >
> > >         at
> > > org.apache.iceberg.parquet.Parquet$WriteBuilder.build(Parquet.java:264)
> > >
> > >         at
> > >
> >
> org.apache.iceberg.parquet.TestDictionaryRowGroupFilter.createInputFile(TestDictionaryRowGroupFilter.java:143)
> > >
> > > Add @Ryan Blue <rb...@netflix.com> as FYI.
> > >
> > > Xinli.
> > >
> > >
> > >
> > >
> > > On Thu, Mar 11, 2021 at 9:39 AM Gabor Szadovszky <ga...@apache.org>
> > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > I propose the following RC to be released as the official Apache
> > Parquet
> > > > 1.12.0 release.
> > > >
> > > > The commit id is 5f2055c30674df8be55eabe7a03d935af1e45e8e
> > > > * This corresponds to the tag: apache-parquet-1.12.0-rc3
> > > > *
> > > >
> > > >
> >
> https://github.com/apache/parquet-mr/tree/5f2055c30674df8be55eabe7a03d935af1e45e8e
> > > >
> > > > The release tarball, signature, and checksums are here:
> > > > *
> > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.12.0-rc3
> > > >
> > > > You can find the KEYS file here:
> > > > * https://downloads.apache.org/parquet/KEYS
> > > >
> > > > Binary artifacts are staged in Nexus here:
> > > > *
> > https://repository.apache.org/content/groups/staging/org/apache/parquet/
> > > >
> > > > This release includes the features Parquet Modular Encryption and
> > Parquet
> > > > Bloom Filter. See details at:
> > > > *
> > > >
> > > >
> >
> https://github.com/apache/parquet-mr/blob/apache-parquet-1.12.0-rc3/CHANGES.md
> > > >
> > > > Please download, verify, and test.
> > > >
> > > > Please vote in the next 72 hours.
> > > >
> > > > [ ] +1 Release this as Apache Parquet 1.12.0
> > > > [ ] +0
> > > > [ ] -1 Do not release this because...
> > > >
> > >
> > >
> > > --
> > > Xinli Shang
> > >
> >
>
>
> --
> Xinli Shang
>