You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2017/05/30 20:34:09 UTC

mesos git commit: Clarify comments on how libprocess chooses its listening port.

Repository: mesos
Updated Branches:
  refs/heads/master 26496483d -> ac1571d24


Clarify comments on how libprocess chooses its listening port.

Review: https://reviews.apache.org/r/59342/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/ac1571d2
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/ac1571d2
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/ac1571d2

Branch: refs/heads/master
Commit: ac1571d248de70680157ed9bf7316eefc96e8c3d
Parents: 2649648
Author: James Peach <jp...@apache.org>
Authored: Tue May 30 13:33:12 2017 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Tue May 30 13:33:12 2017 -0700

----------------------------------------------------------------------
 3rdparty/libprocess/src/process.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/ac1571d2/3rdparty/libprocess/src/process.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/process.cpp b/3rdparty/libprocess/src/process.cpp
index efe75a7..20ac83d 100644
--- a/3rdparty/libprocess/src/process.cpp
+++ b/3rdparty/libprocess/src/process.cpp
@@ -1153,9 +1153,9 @@ bool initialize(
     __address__.port = flags.advertise_port.get();
   }
 
-  // Lookup hostname if missing ip or if ip is 0.0.0.0 in case we
-  // actually have a valid external ip address. Note that we need only
-  // one ip address, so that other processes can send and receive and
+  // Resolve the hostname if ip is 0.0.0.0 in case we actually have
+  // a valid external IP address. Note that we need only one IP
+  // address, so that other processes can send and receive and
   // don't get confused as to whom they are sending to.
   if (__address__.ip.isAny()) {
     char hostname[512];
@@ -1164,7 +1164,7 @@ bool initialize(
       PLOG(FATAL) << "Failed to initialize, gethostname";
     }
 
-    // Lookup IP address of local hostname.
+    // Lookup an IP address of local hostname, taking the first result.
     Try<net::IP> ip = net::getIP(hostname, __address__.ip.family());
 
     if (ip.isError()) {