You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by michaelsembwever <gi...@git.apache.org> on 2018/02/19 01:16:00 UTC
[GitHub] cassandra-dtest pull request #19: New test for CASSANDRA-11381: Node running...
GitHub user michaelsembwever opened a pull request:
https://github.com/apache/cassandra-dtest/pull/19
New test for CASSANDRA-11381: Node running with join_ring=false and authentication can not serve requests
Follow up to CASSANDRA-11381 and https://github.com/riptano/cassandra-dtest/pull/1479
I think the concerns raised previously [here|https://github.com/riptano/cassandra-dtest/pull/1479#issuecomment-315443711] have been addressed. fyi @jkni , @ptnapoleon
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thelastpickle/cassandra-dtest mck/master_11381
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra-dtest/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit e6daf37605e50964fdc0a141e927b37d715b6820
Author: mck <mi...@...>
Date: 2017-05-03T08:29:10Z
New test for CASSANDRA-11381: Node running with join_ring=false and authentication can not serve requests
Patch by Mick Semb Wever; Reviewed by XXX for CASSANDRA-11381
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest issue #19: New test for CASSANDRA-11381: Node running with j...
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on the issue:
https://github.com/apache/cassandra-dtest/pull/19
> I believe pep8 will complain about the lack of a new line at the bottom
I did not know about that! Fixed.
Will merge.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest issue #19: New test for CASSANDRA-11381: Node running with j...
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on the issue:
https://github.com/apache/cassandra-dtest/pull/19
@ptnapoleon ping
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest pull request #19: New test for CASSANDRA-11381: Node running...
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/19#discussion_r169173002
--- Diff: auth_join_ring_false_test.py ---
@@ -0,0 +1,212 @@
+import pytest
+import logging
+
+from cassandra import AuthenticationFailed, Unauthorized
+from cassandra.cluster import NoHostAvailable
+
+from dtest import Tester
+
+
+class TestAuth(Tester):
+
+
+ def test_login_existing_node(self):
+ """
+ * Launch a three node cluster
+ * Restart the third node in `join_ring=false` mode
+ * Connect as the default user/password
+ * Verify that default user w/ bad password gives AuthenticationFailed exception
+ * Verify that bad user gives AuthenticationFailed exception
+ #"""
--- End diff --
oops. fixed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest pull request #19: New test for CASSANDRA-11381: Node running...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cassandra-dtest/pull/19
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest pull request #19: New test for CASSANDRA-11381: Node running...
Posted by ptnapoleon <gi...@git.apache.org>.
Github user ptnapoleon commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/19#discussion_r169038355
--- Diff: auth_join_ring_false_test.py ---
@@ -0,0 +1,212 @@
+import pytest
+import logging
+
+from cassandra import AuthenticationFailed, Unauthorized
+from cassandra.cluster import NoHostAvailable
+
+from dtest import Tester
+
+
+class TestAuth(Tester):
+
+
+ def test_login_existing_node(self):
+ """
+ * Launch a three node cluster
+ * Restart the third node in `join_ring=false` mode
+ * Connect as the default user/password
+ * Verify that default user w/ bad password gives AuthenticationFailed exception
+ * Verify that bad user gives AuthenticationFailed exception
+ #"""
--- End diff --
Seems like there's a loose # here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org