You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/05/31 06:32:46 UTC

[GitHub] [netbeans] eirikbakke opened a new pull request #2981: Have clicking in "Projects" tree work along entire row

eirikbakke opened a new pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981

In the TreeView component, which is used for the "Projects" tab in the NetBeans IDE, the user should be able to click anywhere to the right of the node's icon to select said node. Drag-and-drop should work similarly.

This usability issue came up during user testing of a NetBeans Platform application. The user complained that files with a short filename were harder to click than files with long names. The user, a software engineer, pointed out that the equivalent tree component in IntelliJ allows the entire row to be clicked or dragged at to target a given node.

TreeView's behavior is derived from its superclass JTree. The OutlineView component does not have the same problem, as it derives from ETable and in turn JTable.

Here's an illustration:
![Clickfix](https://user-images.githubusercontent.com/886243/120149972-753ce380-c1b8-11eb-8b0d-cc17514b66df.png)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

sdedic commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-854201504


   > external Darcula LAF
   
   Yes, the external Darcula (I have version 1.6 installed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-852131593


   Makes sense--it's kind of a breaking change, since previous uses of TreeView may assume that the root context menu is available more easily than it would be with the new behavior.
   
   Is there interest in having this as an option for TreeView that can be enabled explicitly? I could update the patch to that effect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

neilcsmith-net commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-851324892


   Possibly -1 as proposed.  How do you provide access to the main Projects popup menu with this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

ebarboni commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-852013548


   Hi, maybe propose as an option. I perso prefers the current design.  Changing for one user seems a bit overkill.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

sdedic commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-853700352






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke edited a comment on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke edited a comment on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-854149082

Did you mean the external Darcula LAF plugin, or the new bundled FlatLAF Dark? I can test either. Now curious how they implemented full-row selection.

The thing with Windows Explorer and other apps that use the full-row behavior, is that the root-level context menu usually just provides shortcuts to actions that are available elsewhere (in the menu bar or in the context menu for individual nodes). So it's just an added convenience for cases where the user has nothing else to click, e.g. before creating a project. But in NetBeans, the "Projects" pane has a few actions which I'm not sure can be accessed in other ways, e.g. "Collapse All" or the "View Java Packages As" option. And if the root context menu has traditionally been easy to access, some people will get used to it over time.

> Note that there was not an argument about the left-click (selection) behaviour

OK, so perhaps left-click should still select the whole row. There's also the behavior when dragging and dropping a node on another node. Here I think it's also good to have the whole row work--I don't think the root node is ever relevant for drag-and-drop.

> A minimum width for the area active for a node right-click, in case the node's text itself is too narrow - expressed in 'eM's ?

I'll experiment with this, and see if there's an approach that feels natural.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-851537789

That's a good question. You can still use the area to the left of nodes for this. Or the area under the last node--though if the content is taller than the scroll viewport, there won't be an area under the last area. So you'd need to collapse the nodes first to access this area.

Windows Explorer also has a special context menu which shows up if you right-click the empty area under the last node, but like here, it does become unavailable if the nodes fill the scroll viewport. Except there always seems to be a little bit of extra space added:

IntelliJ has the same problem--in their case, there is no way to bring up the node-neutral context menu if the scroll viewport is full.

Any suggestions?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke edited a comment on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke edited a comment on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-854149082






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-854149082

Did you mean the external Darcula LAF plugin, or the new bundled FlatLAF Dark? I can test either. Now curious how they implemented full-row selection.

> Note that there was not an argument about the left-click (selection) behaviour
OK, so perhaps this one should still select the whole row. There's also the behavior when dragging and dropping a node on another node. Here I think it's also good to have the whole row work--I don't think the root node is ever relevant here.

> A minimum width for the area active for a node right-click, in case the node's text itself is too narrow - expressed in 'eM's ?
I'll experiment with this, and see if there's an approach that feels natural.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke edited a comment on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke edited a comment on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-851537789


   That's a good question. You can still use the area to the left of nodes for this. Or the area under the last node--though if the content is taller than the scroll viewport, there won't be an area under the last area. So you'd need to collapse the nodes first to access this area.
   
   Windows Explorer also has a special context menu which shows up if you right-click the empty area under the last node, but like here, it does become unavailable if the nodes fill the scroll viewport. Except there always seems to be a little bit of extra space added:
   
   <img width="353" alt="explorer" src="https://user-images.githubusercontent.com/886243/120209672-f28a4780-c1fc-11eb-8d94-9f2e6bb32032.png">
   
   IntelliJ has the same problem--in their case, there is no way to bring up the node-neutral context menu if the scroll viewport is full (even though such a context menu does exist):
   
   <img width="409" alt="intellij" src="https://user-images.githubusercontent.com/886243/120210387-b7d4df00-c1fd-11eb-88ce-993350220546.png">
   
   Any suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke edited a comment on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke edited a comment on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-854149082

Did you mean the external Darcula LAF plugin, or the new bundled FlatLAF Dark? I can test either. Now curious how they implemented full-row selection.

> Note that there was not an argument about the left-click (selection) behaviour

OK, so perhaps this one should still select the whole row. There's also the behavior when dragging and dropping a node on another node. Here I think it's also good to have the whole row work--I don't think the root node is ever relevant here.

> A minimum width for the area active for a node right-click, in case the node's text itself is too narrow - expressed in 'eM's ?

I'll experiment with this, and see if there's an approach that feels natural.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

neilcsmith-net commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-852000534


   > Any suggestions?
   
   Right now, no.  Maybe the extra space.  But replacing one usability issue with another doesn't seem a good idea.  Maybe it's just my workflow, but I know I tend to use the node-neutral context menu a lot, and usually have enough projects open that the scroll viewport is full.  Also, which other views would be affected by this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-854149082

Did you mean the external Darcula LAF plugin, or the new bundled FlatLAF Dark? I can test either. Now curious how they implemented full-row selection.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

lkishalmi commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-882056399


   Well, I kind of like how this is working with the current implementation even with FlatLAF. FlatLAF paints the whole row as selected, but the row-popup context menu is only displayed if you right-click on the text. Otherwise the selection background clears and you get the project context popup.
   It's not that consistent, maybe just the 10++ years wiring likes that in my brain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

sdedic commented on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-853700352

FWIW, the Darcula L&F has the selection active on the entire line out of the box. Pls. test that this does not break with your changes. However the context right click only works on the node labels' area.

I have also tried the Windows Explorer - they really have an usability issue: I managed to get just items from a single parent filling the entire tree viewport and there was NO space to click for the non-contex right-click menu.

Note that there was not an argument about the left-click (selection) behaviour, but just about the context menu: the usability issue to solve is that the area to right click may be **too narrow**. It's actually accessible always as the node icon (but not the expand handle!) works for right-click even for a "one space" name, so I wouldn't trade impossibility to right-click for the main menu for 'just' increased availability of the context menu.

What about a compromise ? A minimum width for the area active for a node right-click, in case the node's text itself is too narrow - expressed in 'eM's ?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke edited a comment on pull request #2981: [NETBEANS-5736] Have clicking in "Projects" tree work along entire row

Posted by GitBox <gi...@apache.org>.

eirikbakke edited a comment on pull request #2981:
URL: https://github.com/apache/netbeans/pull/2981#issuecomment-851537789


   That's a good question. You can still use the area to the left of nodes for this. Or the area under the last node--though if the content is taller than the scroll viewport, there won't be an area under the last area. So you'd need to collapse the nodes first to access this area.
   
   Windows Explorer also has a special context menu which shows up if you right-click the empty area under the last node, but like here, it does become unavailable if the nodes fill the scroll viewport. Except there always seems to be a little bit of extra space added:
   
   <img width="353" alt="explorer" src="https://user-images.githubusercontent.com/886243/120209672-f28a4780-c1fc-11eb-8d94-9f2e6bb32032.png">
   
   IntelliJ has the same problem--in their case, there is no way to bring up the node-neutral context menu if the scroll viewport is full (even though such a context menu does exist).
   
   Any suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists