You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/21 20:02:05 UTC
[GitHub] [incubator-superset] kstrz opened a new pull request #12161: Testing/world bank examples
kstrz opened a new pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161
### SUMMARY
Replace World Bank data example with data loaded by fixture for tests. The aim was to get rid of an external dependency.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
All tests should be green.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12161: Test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (d7cd3ad) into [master](https://codecov.io/gh/apache/incubator-superset/commit/794d31898943e54683af430aa999cd70b916aadd?el=desc) (794d318) will **decrease** coverage by `2.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
- Coverage 63.75% 61.21% -2.54%
==========================================
Files 957 510 -447
Lines 47071 19283 -27788
Branches 4608 4979 +371
==========================================
- Hits 30012 11805 -18207
+ Misses 16874 7278 -9596
- Partials 185 200 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.21% <ø> (-1.44%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-93.34%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-41.38%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [...rc/views/CRUD/alert/components/AlertStatusIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9BbGVydFN0YXR1c0ljb24udHN4) | `46.87% <0.00%> (-17.23%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.58% <0.00%> (-16.92%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `69.23% <0.00%> (-10.77%)` | :arrow_down: |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `60.86% <0.00%> (-9.97%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `78.94% <0.00%> (-8.56%)` | :arrow_down: |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-7.28%)` | :arrow_down: |
| ... and [590 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [794d318...d7cd3ad](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (dadd9e2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/794d31898943e54683af430aa999cd70b916aadd?el=desc) (794d318) will **decrease** coverage by `0.49%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
- Coverage 63.75% 63.26% -0.50%
==========================================
Files 957 484 -473
Lines 47071 29757 -17314
Branches 4608 0 -4608
==========================================
- Hits 30012 18825 -11187
+ Misses 16874 10932 -5942
+ Partials 185 0 -185
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.26% <20.83%> (-1.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <20.83%> (-69.02%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `85.96% <0.00%> (-14.04%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [539 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [794d318...dadd9e2](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#discussion_r552033727
##########
File path: tests/dashboards/commands_tests.py
##########
@@ -78,79 +82,148 @@ def test_export_dashboard_command(self, mock_g1, mock_g2):
assert metadata == {
"dashboard_title": "World Bank's Data",
"description": None,
- "css": "",
+ "css": None,
"slug": "world_health",
"uuid": str(example_dashboard.uuid),
"position": {
- "DASHBOARD_CHART_TYPE-0": {
+ "CHART-36bfc934": {
+ "children": [],
+ "id": "CHART-36bfc934",
+ "meta": {"height": 25, "sliceName": "Region Filter", "width": 2},
+ "type": "CHART",
+ },
+ "CHART-37982887": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-0",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-37982887",
+ "meta": {
+ "height": 25,
+ "sliceName": "World's Population",
+ "width": 2,
+ },
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-1": {
+ "CHART-17e0f8d8": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-1",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-17e0f8d8",
+ "meta": {
+ "height": 92,
+ "sliceName": "Most Populated Countries",
+ "width": 3,
+ },
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-2": {
+ "CHART-2ee52f30": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-2",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-2ee52f30",
+ "meta": {"height": 38, "sliceName": "Growth Rate", "width": 6},
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-3": {
+ "CHART-2d5b6871": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-3",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-2d5b6871",
+ "meta": {"height": 52, "sliceName": "% Rural", "width": 7},
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-4": {
+ "CHART-0fd0d252": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-4",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-0fd0d252",
+ "meta": {
+ "height": 50,
+ "sliceName": "Life Expectancy VS Rural %",
+ "width": 8,
+ },
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-5": {
+ "CHART-97f4cb48": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-5",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-97f4cb48",
+ "meta": {"height": 38, "sliceName": "Rural Breakdown", "width": 3},
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-6": {
+ "CHART-b5e05d6f": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-6",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-b5e05d6f",
+ "meta": {
+ "height": 50,
+ "sliceName": "World's Pop Growth",
+ "width": 4,
+ },
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-7": {
+ "CHART-e76e9f5f": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-7",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-e76e9f5f",
+ "meta": {"height": 50, "sliceName": "Box plot", "width": 4},
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-8": {
+ "CHART-a4808bba": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-8",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-a4808bba",
+ "meta": {"height": 50, "sliceName": "Treemap", "width": 8},
"type": "CHART",
},
- "DASHBOARD_CHART_TYPE-9": {
+ "CHART-3nc0d8sk": {
"children": [],
- "id": "DASHBOARD_CHART_TYPE-9",
- "meta": {"height": 50, "width": 4},
+ "id": "CHART-3nc0d8sk",
+ "meta": {"height": 50, "sliceName": "Treemap", "width": 8},
"type": "CHART",
},
+ "COLUMN-071bbbad": {
+ "children": ["ROW-1e064e3c", "ROW-afdefba9"],
+ "id": "COLUMN-071bbbad",
+ "meta": {"background": "BACKGROUND_TRANSPARENT", "width": 9},
+ "type": "COLUMN",
+ },
+ "COLUMN-fe3914b8": {
+ "children": ["CHART-36bfc934", "CHART-37982887"],
+ "id": "COLUMN-fe3914b8",
+ "meta": {"background": "BACKGROUND_TRANSPARENT", "width": 2},
+ "type": "COLUMN",
+ },
+ "GRID_ID": {
+ "children": ["ROW-46632bc2", "ROW-3fa26c5d", "ROW-812b3f13"],
+ "id": "GRID_ID",
+ "type": "GRID",
+ },
+ "HEADER_ID": {
+ "id": "HEADER_ID",
+ "meta": {"text": "World's Bank Data"},
+ "type": "HEADER",
+ },
+ "ROOT_ID": {"children": ["GRID_ID"], "id": "ROOT_ID", "type": "ROOT"},
+ "ROW-1e064e3c": {
+ "children": ["COLUMN-fe3914b8", "CHART-2d5b6871"],
+ "id": "ROW-1e064e3c",
+ "meta": {"background": "BACKGROUND_TRANSPARENT"},
+ "type": "ROW",
+ },
+ "ROW-3fa26c5d": {
+ "children": ["CHART-b5e05d6f", "CHART-0fd0d252"],
+ "id": "ROW-3fa26c5d",
+ "meta": {"background": "BACKGROUND_TRANSPARENT"},
+ "type": "ROW",
+ },
+ "ROW-46632bc2": {
+ "children": ["COLUMN-071bbbad", "CHART-17e0f8d8"],
+ "id": "ROW-46632bc2",
+ "meta": {"background": "BACKGROUND_TRANSPARENT"},
+ "type": "ROW",
+ },
+ "ROW-812b3f13": {
+ "children": ["CHART-a4808bba", "CHART-e76e9f5f"],
+ "id": "ROW-812b3f13",
+ "meta": {"background": "BACKGROUND_TRANSPARENT"},
+ "type": "ROW",
+ },
+ "ROW-afdefba9": {
+ "children": ["CHART-2ee52f30", "CHART-97f4cb48"],
+ "id": "ROW-afdefba9",
+ "meta": {"background": "BACKGROUND_TRANSPARENT"},
+ "type": "ROW",
+ },
"DASHBOARD_VERSION_KEY": "v2",
},
- "metadata": {
- "timed_refresh_immune_slices": [],
- "expanded_slices": {},
- "refresh_frequency": 0,
- "default_filters": "{}",
- "color_scheme": None,
- },
+ "metadata": {"mock_key": "mock_value"},
Review comment:
Why the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (70db575) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **increase** coverage by `0.89%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
+ Coverage 63.06% 63.95% +0.89%
==========================================
Files 994 484 -510
Lines 49075 29765 -19310
Branches 4984 0 -4984
==========================================
- Hits 30950 19037 -11913
+ Misses 17925 10728 -7197
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.95% <20.83%> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <20.83%> (-69.02%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.55% <0.00%> (-1.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [513 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [93af329...70db575](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (f149fea) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3bbbf8ea33fbec5a58fc07f56d2fd8fdf30135f?el=desc) (a3bbbf8) will **decrease** coverage by `3.90%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
- Coverage 67.11% 63.21% -3.91%
==========================================
Files 996 485 -511
Lines 49176 29797 -19379
Branches 4993 0 -4993
==========================================
- Hits 33006 18837 -14169
+ Misses 16047 10960 -5087
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.21% <20.83%> (-1.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <20.83%> (-69.02%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.22% <0.00%> (-6.28%)` | :arrow_down: |
| ... and [525 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [a3bbbf8...f149fea](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (70db575) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **increase** coverage by `0.74%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
+ Coverage 63.06% 63.81% +0.74%
==========================================
Files 994 484 -510
Lines 49075 29750 -19325
Branches 4984 0 -4984
==========================================
- Hits 30950 18985 -11965
+ Misses 17925 10765 -7160
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.81% <20.83%> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <20.83%> (-69.02%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.55% <0.00%> (-1.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.77% <0.00%> (-1.09%)` | :arrow_down: |
| ... and [523 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [93af329...70db575](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (70db575) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **increase** coverage by `0.10%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
+ Coverage 63.06% 63.16% +0.10%
==========================================
Files 994 484 -510
Lines 49075 29750 -19325
Branches 4984 0 -4984
==========================================
- Hits 30950 18793 -12157
+ Misses 17925 10957 -6968
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.16% <20.83%> (-1.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <20.83%> (-69.02%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [93af329...70db575](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (70db575) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **increase** coverage by `0.88%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
+ Coverage 63.06% 63.94% +0.88%
==========================================
Files 994 484 -510
Lines 49075 29765 -19310
Branches 4984 0 -4984
==========================================
- Hits 30950 19034 -11916
+ Misses 17925 10731 -7194
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.94% <20.83%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <20.83%> (-69.02%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.55% <0.00%> (-1.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| ... and [514 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [93af329...70db575](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (22dbb92) into [master](https://codecov.io/gh/apache/incubator-superset/commit/794d31898943e54683af430aa999cd70b916aadd?el=desc) (794d318) will **decrease** coverage by `2.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
- Coverage 63.75% 61.23% -2.53%
==========================================
Files 957 510 -447
Lines 47071 19297 -27774
Branches 4608 4979 +371
==========================================
- Hits 30012 11816 -18196
+ Misses 16874 7281 -9593
- Partials 185 200 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.23% <ø> (-1.43%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-93.34%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-41.38%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [...rc/views/CRUD/alert/components/AlertStatusIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9BbGVydFN0YXR1c0ljb24udHN4) | `46.87% <0.00%> (-17.23%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.58% <0.00%> (-16.92%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `69.23% <0.00%> (-10.77%)` | :arrow_down: |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `60.86% <0.00%> (-9.97%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `78.94% <0.00%> (-8.56%)` | :arrow_down: |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-7.28%)` | :arrow_down: |
| ... and [595 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [794d318...22dbb92](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (70db575) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **increase** coverage by `0.73%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
+ Coverage 63.06% 63.80% +0.73%
==========================================
Files 994 484 -510
Lines 49075 29765 -19310
Branches 4984 0 -4984
==========================================
- Hits 30950 18992 -11958
+ Misses 17925 10773 -7152
+ Partials 200 0 -200
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.80% <20.83%> (-0.46%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <20.83%> (-69.02%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.55% <0.00%> (-1.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.77% <0.00%> (-1.09%)` | :arrow_down: |
| ... and [516 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [93af329...70db575](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (1429a91) into [master](https://codecov.io/gh/apache/incubator-superset/commit/794d31898943e54683af430aa999cd70b916aadd?el=desc) (794d318) will **decrease** coverage by `2.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
- Coverage 63.75% 61.23% -2.53%
==========================================
Files 957 510 -447
Lines 47071 19297 -27774
Branches 4608 4979 +371
==========================================
- Hits 30012 11816 -18196
+ Misses 16874 7281 -9593
- Partials 185 200 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `61.23% <ø> (-1.43%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-93.34%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (-41.38%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [...rc/views/CRUD/alert/components/AlertStatusIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9BbGVydFN0YXR1c0ljb24udHN4) | `46.87% <0.00%> (-17.23%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.58% <0.00%> (-16.92%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `69.23% <0.00%> (-10.77%)` | :arrow_down: |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `60.86% <0.00%> (-9.97%)` | :arrow_down: |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | `78.94% <0.00%> (-8.56%)` | :arrow_down: |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `72.72% <0.00%> (-7.28%)` | :arrow_down: |
| ... and [595 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [794d318...1429a91](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12161: test: World bank examples
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12161:
URL: https://github.com/apache/incubator-superset/pull/12161#issuecomment-749197996
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=h1) Report
> Merging [#12161](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=desc) (f149fea) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3bbbf8ea33fbec5a58fc07f56d2fd8fdf30135f?el=desc) (a3bbbf8) will **decrease** coverage by `3.89%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
- Coverage 67.11% 63.22% -3.90%
==========================================
Files 996 485 -511
Lines 49176 29797 -19379
Branches 4993 0 -4993
==========================================
- Hits 33006 18840 -14166
+ Misses 16047 10957 -5090
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.22% <20.83%> (-1.00%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <20.83%> (-69.02%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.22% <0.00%> (-6.28%)` | :arrow_down: |
| ... and [524 more](https://codecov.io/gh/apache/incubator-superset/pull/12161/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=footer). Last update [a3bbbf8...f149fea](https://codecov.io/gh/apache/incubator-superset/pull/12161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org