You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2026/09/15 12:17:00 UTC
[jira] [Work logged] (KNOX-3457) Remove unused delegation.requested.scope.enabled provider parameter
[ https://issues.apache.org/jira/browse/KNOX-3457?focusedWorklogId=1041648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1041648 ]
ASF GitHub Bot logged work on KNOX-3457:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/26 12:16
Start Date: 15/Sep/26 12:16
Worklog Time Spent: 10m
Work Description: smolnar82 opened a new pull request, #1399:
URL: https://github.com/apache/knox/pull/1399
[KNOX-3457](https://issues.apache.org/jira/browse/KNOX-3457) - Remove unused delegation.requested.scope.enabled provider parameter
## What changes were proposed in this pull request?
Removes the dead `delegation.requested.scope.enabled` provider parameter introduced with KNOX-3441. It was read into a field and exposed via `isDelegationRequestedScopeEnabled()`, but the getter had no production callers — scope is never parsed from the exchange request (`TokenExchangeHandler` always passes an empty `requestedScopes` set), so the flag had no behavioral effect.
- `JWTFederationFilter`: removed the constant and its comment block, the `delegationRequestedScopeEnabled` field, the init-param read, and the `isDelegationRequestedScopeEnabled()` getter.
- `JWTFederationFilterDelegationConfigTest`: dropped the scope assertions from the shared cases, deleted the dedicated scope test, and removed the scope property from the all-flags test.
- `HadoopAuthFilterTest`: removed the now-obsolete mock stub for the parameter.
Pure dead-code removal — no behavior change. Actually implementing requested-scope for token exchange is tracked separately.
## How was this patch tested?
- Repo-wide grep confirms no remaining references to the constant, field, getter, or `"delegation.requested.scope.enabled"` string.
- `mvn -pl gateway-provider-security-jwt,gateway-provider-security-hadoopauth -am test -Dtest=JWTFederationFilterDelegationConfigTest,HadoopAuthFilterTest`: `JWTFederationFilterDelegationConfigTest` 7/7 and `HadoopAuthFilterTest` 12/12 pass.
## Integration Tests
N/A
Issue Time Tracking
-------------------
Worklog Id: (was: 1041648)
Remaining Estimate: 0h
Time Spent: 10m
> Remove unused delegation.requested.scope.enabled provider parameter
> -------------------------------------------------------------------
>
> Key: KNOX-3457
> URL: https://issues.apache.org/jira/browse/KNOX-3457
> Project: Apache Knox
> Issue Type: Sub-task
> Components: Server
> Affects Versions: 3.1.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 3.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The delegation.requested.scope.enabled provider parameter ({{JWTFederationFilter.DELEGATION_REQUESTED_SCOPE_ENABLED}}) is read into a field and exposed via {{isDelegationRequestedScopeEnabled()}}, but the getter has no production callers, it is referenced only by config-parse tests. Scope is never parsed from the exchange request, so the flag has no behavioral effect.
> Scope: Remove the constant, field, init-param read, and getter from {{JWTFederationFilter}}; drop the scope cases from {{JWTFederationFilterDelegationConfigTest}}; and remove the corresponding mock stub in {{HadoopAuthFilterTest}}. Purely dead-code removal; no behavior change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)