You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by maoling <gi...@git.apache.org> on 2018/07/04 09:30:02 UTC

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/548#discussion_r200064561
  
    --- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java ---
    @@ -60,4 +60,25 @@ static public String getClientConfigStr(String configData) {
             }
             return version + " " + sb.toString();
         }
    +
    +    public static String[] splitServerConfig(String s)
    +        throws ConfigException
    +    {
    +        /* Does it start with an IPv6 literal? */
    --- End diff --
    
    remove this line annotation and give this method detailed javadoc


---