You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by is...@apache.org on 2017/05/26 22:00:40 UTC
lucene-solr:master: SOLR-10735: Fixing windows space directory issue
Repository: lucene-solr
Updated Branches:
refs/heads/master 8f92fb472 -> 45b26e322
SOLR-10735: Fixing windows space directory issue
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/45b26e32
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/45b26e32
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/45b26e32
Branch: refs/heads/master
Commit: 45b26e322f1e173c8a19f07700e64daa5475da84
Parents: 8f92fb4
Author: Ishan Chattopadhyaya <is...@apache.org>
Authored: Sat May 27 03:30:27 2017 +0530
Committer: Ishan Chattopadhyaya <is...@apache.org>
Committed: Sat May 27 03:30:27 2017 +0530
----------------------------------------------------------------------
solr/CHANGES.txt | 3 +++
solr/core/src/java/org/apache/solr/util/SolrCLI.java | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/45b26e32/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index cd383d1..7d15bef 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -477,6 +477,9 @@ Bug Fixes
"lucene"/standard query parser, should require " TO " in range queries,
and accept "TO" as endpoints in range queries. (hossman, Steve Rowe)
+* SOLR-10735: Windows script (solr.cmd) didn't work properly with directory containing spaces. Adding quotations
+ to fix (Uwe Schindler, janhoy, Tomas Fernandez-Lobbe, Ishan Chattopadhyaya)
+
Other Changes
----------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/45b26e32/solr/core/src/java/org/apache/solr/util/SolrCLI.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/util/SolrCLI.java b/solr/core/src/java/org/apache/solr/util/SolrCLI.java
index 97fdf1e..51ab5d7 100644
--- a/solr/core/src/java/org/apache/solr/util/SolrCLI.java
+++ b/solr/core/src/java/org/apache/solr/util/SolrCLI.java
@@ -2941,7 +2941,7 @@ public class SolrCLI {
solrHome = solrHome.substring(cwdPath.length()+1);
String startCmd =
- String.format(Locale.ROOT, "%s start %s -p %d -s \"%s\" %s %s %s %s %s %s",
+ String.format(Locale.ROOT, "\"%s\" start %s -p %d -s \"%s\" %s %s %s %s %s %s",
callScript, cloudModeArg, port, solrHome, hostArg, zkHostArg, memArg, forceArg, extraArgs, addlOptsArg);
startCmd = startCmd.replaceAll("\\s+", " ").trim(); // for pretty printing