You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/21 08:03:50 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3209: [GOBBLIN-1367] Fix PostgresqlExtractor's unnecessary string replacement
codecov-io edited a comment on pull request #3209:
URL: https://github.com/apache/incubator-gobblin/pull/3209#issuecomment-764450255
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3209?src=pr&el=h1) Report
> Merging [#3209](https://codecov.io/gh/apache/incubator-gobblin/pull/3209?src=pr&el=desc) (07d9511) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/2fa3553c75775d2d2a3a98f51c92b5c758c7abc9?el=desc) (2fa3553) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3209?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3209 +/- ##
============================================
- Coverage 46.23% 46.23% -0.01%
- Complexity 9788 9797 +9
============================================
Files 2019 2019
Lines 77439 77504 +65
Branches 8602 8606 +4
============================================
+ Hits 35807 35837 +30
- Misses 38300 38334 +34
- Partials 3332 3333 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3209?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/gobblin/source/jdbc/PostgresqlExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL1Bvc3RncmVzcWxFeHRyYWN0b3IuamF2YQ==) | `50.00% <100.00%> (+20.17%)` | `14.00 <0.00> (+2.00)` | |
| [...obblin/yarn/YarnAppSecurityManagerWithKeytabs.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkFwcFNlY3VyaXR5TWFuYWdlcldpdGhLZXl0YWJzLmphdmE=) | `8.33% <0.00%> (-13.55%)` | `1.00% <0.00%> (-1.00%)` | |
| [...he/gobblin/source/PartitionAwareFileRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9QYXJ0aXRpb25Bd2FyZUZpbGVSZXRyaWV2ZXIuamF2YQ==) | `48.14% <0.00%> (-7.41%)` | `0.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `32.23% <0.00%> (-5.79%)` | `12.00% <0.00%> (-2.00%)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `58.06% <0.00%> (-2.16%)` | `6.00% <0.00%> (ø%)` | |
| [...n/java/org/apache/gobblin/yarn/YarnHelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkhlbGl4VXRpbHMuamF2YQ==) | `32.69% <0.00%> (-2.01%)` | `8.00% <0.00%> (ø%)` | |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `24.10% <0.00%> (-0.06%)` | `12.00% <0.00%> (ø%)` | |
| [...ava/org/apache/gobblin/util/hadoop/TokenUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvaGFkb29wL1Rva2VuVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...e/gobblin/yarn/AbstractYarnAppSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vQWJzdHJhY3RZYXJuQXBwU2VjdXJpdHlNYW5hZ2VyLmphdmE=) | `49.47% <0.00%> (+1.19%)` | `7.00% <0.00%> (+1.00%)` | |
| [...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=) | `75.33% <0.00%> (+1.33%)` | `32.00% <0.00%> (+1.00%)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3209/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3209?src=pr&el=footer). Last update [2fa3553...07d9511](https://codecov.io/gh/apache/incubator-gobblin/pull/3209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org