You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2021/05/25 07:32:17 UTC

[james-mime4j] 02/05: [REFACTORING] AbstractEntityBuilder was colling toLowerCase twice

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git

commit 4551299e1de15281d42b42c21231bb0eb8f1fd40
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Mon May 24 07:30:27 2021 +0700

    [REFACTORING] AbstractEntityBuilder was colling toLowerCase twice
---
 .../java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dom/src/main/java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java b/dom/src/main/java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java
index e5e12b2..5561c5a 100644
--- a/dom/src/main/java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java
+++ b/dom/src/main/java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java
@@ -66,10 +66,11 @@ public abstract class AbstractEntityBuilder {
      * @param field the field to add.
      */
     public AbstractEntityBuilder addField(Field field) {
-        List<Field> values = fieldMap.get(field.getName().toLowerCase(Locale.US));
+        String lowerCasedFieldName = field.getName().toLowerCase(Locale.US);
+        List<Field> values = fieldMap.get(lowerCasedFieldName);
         if (values == null) {
             values = new LinkedList<Field>();
-            fieldMap.put(field.getName().toLowerCase(Locale.US), values);
+            fieldMap.put(lowerCasedFieldName, values);
         }
         values.add(field);
         fields.add(field);

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org