You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kayousterhout <gi...@git.apache.org> on 2014/07/07 08:27:53 UTC
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/1314
[SPARK-2384] Add tooltips to UI.
This patch adds tooltips to clarify some points of confusion in the UI. When users mouse over some of the table headers (shuffle read, write, and input size) as well as over the "scheduler delay" metric shown for each stage, a black tool tip (see image below) pops up describing the metric in more detail. After the tooltip mechanism is added by this commit, I imagine others may want to add more tooltips for other things in the UI, but I think this is a good starting point.
This looks scary-big but much of it is adding the bootstrap tool tip JavaScript.
Also I have no idea what to put for the license in tooltip (I left it the same -- the Twitter apache header) or for JQuery (left it as nothing) -- @mateiz what's the right thing here?
cc @pwendell @andrewor14 @rxin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kayousterhout/spark-1 tooltips
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1314
----
commit 77524490754c47f3e78904087cd582741419abe5
Author: Kay Ousterhout <ka...@gmail.com>
Date: 2014-07-07T05:59:18Z
[SPARK-2384] Add tooltips to UI.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48281532
You can exclude the licensing check by editing .rat-excludes file.
One thing I'm not sure about is whether it is worth it to introduce jquery and other library just for the sake of a tooltip. We can probably implement the hover tooltip thing in a few lines of JavaScript code ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48389063
Jenkins, retest this please
On Tue, Jul 8, 2014 at 12:31 PM, UCB AMPLab <no...@github.com>
wrote:
> Merged build finished.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/1314#issuecomment-48388710>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48402305
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48388712
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16417/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609615
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala ---
@@ -36,8 +52,41 @@ private[ui] class ExecutorsPage(parent: ExecutorsTab) extends WebUIPage("") {
val memUsed = storageStatusList.map(_.memUsed).fold(0L)(_ + _)
val diskSpaceUsed = storageStatusList.flatMap(_.blocks.values.map(_.diskSize)).fold(0L)(_ + _)
val execInfo = for (statusId <- 0 until storageStatusList.size) yield getExecInfo(statusId)
- val execInfoSorted = execInfo.sortBy(_.getOrElse("Executor ID", ""))
- val execTable = UIUtils.listingTable(execHeader, execRow, execInfoSorted)
+ val execInfoSorted = execInfo.sortBy(_.id)
+
+ val execTable =
+ <table class={UIUtils.TABLE_CLASS}>
+ <thead>
+ <th>Executor ID</th>
+ <th>Address</th>
+ <th>RDD Blocks</th>
+ <th>Memory Used</th>
+ <th>Disk Used</th>
+ <th>Active Tasks</th>
+ <th>Failed Tasks</th>
+ <th>Complete Tasks</th>
+ <th>Total Tasks</th>
+ <th>Task Time</th>
+ <th>
+ <span data-toggle="tooltip" title={ToolTips.INPUT}>
+ Input
+ </span>
+ </th>
+ <th>
+ <span data-toggle="tooltip" title={ToolTips.SHUFFLE_READ}>
+ Shuffle Read
+ </span>
+ </th>
+ <th>
+ <span data-toggle="tooltip" data-placement="left" title={ToolTips.SHUFFLE_WRITE}>
--- End diff --
what does `data-placement="left"` do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48244066
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609688
--- Diff: core/src/main/scala/org/apache/spark/ui/ToolTips.scala ---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui
+
+object ToolTips {
--- End diff --
It might be good to mark this \@DeveloperApi (or make it `private[spark]`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48387408
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48395752
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48395433
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48244067
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16387/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48243892
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48144930
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48432789
Merging this in master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48373784
Hi @andrewor14
We would need to at least keep a local fallback of the jquery even if we use a CDN version because a lot of production Spark deployments don't actually have access to the external Internet.
For visualization, it is not yet clear what we are going to include in the future. And even if we do, most visualization libs work perfectly fine without jquery. I was not advocating re-implementing all the features of all these libraries. Rather, most of the time it is trivial to implement the functionalities we need via vanilla JS. In this case, I bet we can implement a comparable tooltip in dozens of lines. If we need more features of jquery, we can pull it in later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48281747
@rxin what if we merged this as-is and then we create a starter jira to write a small library for doing tooltips and remove jquery? I think @kayousterhout probably doesn't have enough time/javascript foo to do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14623050
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -139,6 +140,17 @@ private[spark] object UIUtils extends Logging {
def prependBaseUri(basePath: String = "", resource: String = "") = uiRoot + basePath + resource
+ val commonHeaderNodes =
+ <meta http-equiv="Content-type" content="text/html; charset=utf-8" />
+ <link rel="stylesheet" href={prependBaseUri("/static/bootstrap.min.css")}
+ type="text/css" />
+ <link rel="stylesheet" href={prependBaseUri("/static/webui.css")}
+ type="text/css" />
+ <script src={prependBaseUri("/static/sorttable.js")} ></script>
+ <script src={prependBaseUri("/static/jquery-1.11.1.min.js")}></script>
+ <script src={prependBaseUri("/static/bootstrap-tooltip.js")}></script>
+ <script src={prependBaseUri("/static/initialize-tooltips.js")}></script>
--- End diff --
Good point -- done (and also fixed the wrong indentation here)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48144921
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48243714
Thanks for the review @andrewor14 -- uploaded a commit addressing your comments!
The Jenkins build is failing because the jquery file doesn't have a license but it's not obvious to me that we should add one -- hoping @mateiz or @pwendell can weigh in here about what to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48387423
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48145125
Awesome. I've been wanting to do this for a long time!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48402309
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16424/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48282767
Definitely we can merge this first. I can submit a PR later to remove jquery.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48395756
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609276
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -139,6 +140,17 @@ private[spark] object UIUtils extends Logging {
def prependBaseUri(basePath: String = "", resource: String = "") = uiRoot + basePath + resource
+ val commonHeaderNodes =
+ <meta http-equiv="Content-type" content="text/html; charset=utf-8" />
+ <link rel="stylesheet" href={prependBaseUri("/static/bootstrap.min.css")}
+ type="text/css" />
+ <link rel="stylesheet" href={prependBaseUri("/static/webui.css")}
+ type="text/css" />
+ <script src={prependBaseUri("/static/sorttable.js")} ></script>
+ <script src={prependBaseUri("/static/jquery-1.11.1.min.js")}></script>
+ <script src={prependBaseUri("/static/bootstrap-tooltip.js")}></script>
+ <script src={prependBaseUri("/static/initialize-tooltips.js")}></script>
--- End diff --
nit: could you wrap this in a `{ }`, right now it's a little scary because this is all DSL, so it's not clear if we suddenly drop a few lines here and there
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609695
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala ---
@@ -36,8 +52,41 @@ private[ui] class ExecutorsPage(parent: ExecutorsTab) extends WebUIPage("") {
val memUsed = storageStatusList.map(_.memUsed).fold(0L)(_ + _)
val diskSpaceUsed = storageStatusList.flatMap(_.blocks.values.map(_.diskSize)).fold(0L)(_ + _)
val execInfo = for (statusId <- 0 until storageStatusList.size) yield getExecInfo(statusId)
- val execInfoSorted = execInfo.sortBy(_.getOrElse("Executor ID", ""))
- val execTable = UIUtils.listingTable(execHeader, execRow, execInfoSorted)
+ val execInfoSorted = execInfo.sortBy(_.id)
+
+ val execTable =
+ <table class={UIUtils.TABLE_CLASS}>
+ <thead>
+ <th>Executor ID</th>
+ <th>Address</th>
+ <th>RDD Blocks</th>
+ <th>Memory Used</th>
+ <th>Disk Used</th>
+ <th>Active Tasks</th>
+ <th>Failed Tasks</th>
+ <th>Complete Tasks</th>
+ <th>Total Tasks</th>
+ <th>Task Time</th>
+ <th>
+ <span data-toggle="tooltip" title={ToolTips.INPUT}>
+ Input
+ </span>
+ </th>
+ <th>
+ <span data-toggle="tooltip" title={ToolTips.SHUFFLE_READ}>
+ Shuffle Read
+ </span>
+ </th>
+ <th>
+ <span data-toggle="tooltip" data-placement="left" title={ToolTips.SHUFFLE_WRITE}>
--- End diff --
It means the tooltip appears to the left instead of on top. I did this because the shuffle write appears on the far right of the table, so the tooltip doesn't fit above it (because it's wider than the shuffle write column)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609068
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala ---
@@ -22,9 +22,25 @@ import javax.servlet.http.HttpServletRequest
import scala.xml.Node
import org.apache.spark.storage.StorageLevel
-import org.apache.spark.ui.{WebUIPage, UIUtils}
+import org.apache.spark.ui.{ToolTips, UIUtils, WebUIPage}
import org.apache.spark.util.Utils
+private case class ExecutorInfo(
--- End diff --
There's already an ExecutorInfo class...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48145003
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48388710
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14623004
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala ---
@@ -22,9 +22,25 @@ import javax.servlet.http.HttpServletRequest
import scala.xml.Node
import org.apache.spark.storage.StorageLevel
-import org.apache.spark.ui.{WebUIPage, UIUtils}
+import org.apache.spark.ui.{ToolTips, UIUtils, WebUIPage}
import org.apache.spark.util.Utils
+private case class ExecutorInfo(
--- End diff --
Thanks for noticing that -- changed to ExecutorSummaryInfo (happy to do something else if you have a another idea)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48369019
In the long run, if we decide to introduce visualization to our UI (e.g. of execution times) we may use another library, possibly on top of jquery. It's not clear to me that we should re-implement all parts of these libraries that we want to use. Maybe instead of including them in Spark we should link them, and only promise these extra features if your SparkUI has internet connection or something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48145004
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16363/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2384] Add tooltips to UI.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48243906
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---