You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kerrishotts <gi...@git.apache.org> on 2017/01/10 05:35:51 UTC
[GitHub] cordova-ios pull request #286: CB-12287: Remove hardcoded simulator build de...
GitHub user kerrishotts opened a pull request:
https://github.com/apache/cordova-ios/pull/286
CB-12287: Remove hardcoded simulator build destination
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS 4.3.1 and below
### What does this PR do?
In `cordova-ios@4.3.1` and below, the Xcode build destination when building for a simulator is hardcoded as "iPhone 5s". This works as long as the user has an iPhone 5s simulator installed, but if they remove it, the build process breaks.
This PR follows the same logic as `cordova emulate ios` in choosing a default destination, but also respects `--target` if specified. For example:
```
$ cordova emulate ios # will currently select iPhone SE simulator to build against and emulate
$ cordova emulate ios --target="iPhone-7-Plus" # will build against and emulate on the iPhone 7+
```
If there are no simulators available, the behavior is undefined, but Xcode wouldn't be able to build either.
### What testing has been done on this change?
Manual tests and `npm test`
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
- Note: a couple of tests were modified so that they could pass, but they don't actually test this issue. Tests covering the inner logic will come in a separate PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kerrishotts/cordova-ios CB-12287
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit 3c0ba16324c44440892beec1fd4c741714836cd2
Author: Kerri Shotts <ks...@apache.org>
Date: 2017-01-10T05:29:00Z
CB-12287: Remove hardcoded simulator build destination
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #286: CB-12287: Remove hardcoded simulator build destinati...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-ios/pull/286
LGTM!
Not a breaking change in my opinion, no major bump required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #286: CB-12287: Remove hardcoded simulator build de...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #286: CB-12287: Remove hardcoded simulator build destinati...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/286
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/286?src=pr) is 63.26% (diff: 13.04%)
> Merging [#286](https://codecov.io/gh/apache/cordova-ios/pull/286?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will decrease coverage by **0.85%**
```diff
@@ master #286 diff @@
==========================================
Files 12 12
Lines 1360 1380 +20
Methods 208 213 +5
Messages 0 0
Branches 229 233 +4
==========================================
+ Hits 872 873 +1
- Misses 488 507 +19
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [7ec3bdb...3c0ba16](https://codecov.io/gh/apache/cordova-ios/compare/7ec3bdb463a5fd806d9d370b294a96f35e361179...3c0ba16324c44440892beec1fd4c741714836cd2?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #286: CB-12287: Remove hardcoded simulator build destinati...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/286
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org