You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2023/01/02 22:14:54 UTC
[GitHub] [commons-lang] esivakumar18 opened a new pull request, #1007: Added new examples for rightPad method
esivakumar18 opened a new pull request, #1007:
URL: https://github.com/apache/commons-lang/pull/1007
Added new examples for `rightPad` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] esivakumar18 commented on pull request #1007: Added new examples for rightPad method
Posted by GitBox <gi...@apache.org>.
esivakumar18 commented on PR #1007:
URL: https://github.com/apache/commons-lang/pull/1007#issuecomment-1370046739
> This does not help, it just makes things bigger without helping users IMO. The additional tests don't even increase code coverage, so there is really little value in even the new assertions IMO.
Hi @garydgregory thank you for the comment. I have added this example to clear some confusion i.e., if we try to do padding on space, it will yield the same result without any padding. Kindly review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] ecki commented on pull request #1007: Added new examples for rightPad method
Posted by GitBox <gi...@apache.org>.
ecki commented on PR #1007:
URL: https://github.com/apache/commons-lang/pull/1007#issuecomment-1370056570
I am also not sure if we need the samples, but i could see some use in explaining that blank is not special, in that case (“ “,3) (similar to („abc“,2) but with blanks is missing.
the sample and tests differ, i would use ,3 in both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] esivakumar18 commented on pull request #1007: Added new examples for rightPad method
Posted by GitBox <gi...@apache.org>.
esivakumar18 commented on PR #1007:
URL: https://github.com/apache/commons-lang/pull/1007#issuecomment-1370047032
@kinow could you please review this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] esivakumar18 closed pull request #1007: Added new examples for rightPad method
Posted by "esivakumar18 (via GitHub)" <gi...@apache.org>.
esivakumar18 closed pull request #1007: Added new examples for rightPad method
URL: https://github.com/apache/commons-lang/pull/1007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1007: Added new examples for rightPad method
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #1007:
URL: https://github.com/apache/commons-lang/pull/1007#issuecomment-1369254980
This does not help, it just makes things bigger without helping users IMO. The additional tests don't even increase code coverage, so there is really little value in even the new assertions IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org