You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/01/17 08:08:03 UTC

[jira] [Commented] (JCLOUDS-1225) Guava 21 compatibility

    [ https://issues.apache.org/jira/browse/JCLOUDS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328436#comment-16328436 ] 

ASF subversion and git services commented on JCLOUDS-1225:
----------------------------------------------------------

Commit 6b8a81335d80fc1aaea2b40714f67abd0915b068 in jclouds's branch refs/heads/master from [~gaul]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=6b8a813 ]

JCLOUDS-1225: Address Guava 18 Objects changes

Fixed with:

find -name \*.java | xargs sed -i 's/Objects.[Tt]oStringHelper/More&/g'
find -name \*.java | xargs sed -i 's/Objects.firstNonNull/More&/g'
find -name \*.java | xargs sed -i 's/^\(import com.google.common.base.\)\(Objects.*\)/\1More\2\n\1\2/g'
find -name \*.java | xargs java -jar google-java-format-1.3-all-deps.jar -i --fix-imports-only --skip-sorting-imports


> Guava 21 compatibility
> ----------------------
>
>                 Key: JCLOUDS-1225
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1225
>             Project: jclouds
>          Issue Type: Improvement
>          Components: jclouds-core
>    Affects Versions: 2.0.0
>            Reporter: Ian Springer
>            Assignee: Andrew Gaul
>            Priority: Major
>              Labels: guava
>             Fix For: 2.1.0
>
>
> The below classes use com.google.common.base.Objects.ToStringHelper, which has been deprecated since Guava 18, and has been removed in Guava 21. This makes it impossible to use jclouds in a project using Guava 21. Please either upgrade to Guava 18+ and switch to using com.google.common.base.MoreObjects.ToStringHelper, or drop the usage of ToStringHelper altogether. This will allow my project to upgrade to Guava 21 without having to use a fork of jclouds.
> * org/jclouds/apis/internal/BaseApiMetadata.java
> * org/jclouds/domain/internal/LocationImpl.java
> * org/jclouds/domain/internal/MutableResourceMetadataImpl.java
> * org/jclouds/domain/internal/ResourceMetadataImpl.java
> * org/jclouds/http/HttpMessage.java
> * org/jclouds/http/HttpRequest.java
> * org/jclouds/http/HttpResponse.java
> * org/jclouds/internal/BaseView.java
> * org/jclouds/providers/internal/BaseProviderMetadata.java
> * org/jclouds/reflect/InvocationSuccess.java
> * org/jclouds/rest/internal/BaseHttpApiMetadata.java
> * org/jclouds/rest/suppliers/URIFromStringSupplier.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)