You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by SangeetaGulia <gi...@git.apache.org> on 2017/12/23 08:51:34 UTC
[GitHub] carbondata pull request #1722: [CARBONDATA-1755] Fixed bug occuring on curre...
GitHub user SangeetaGulia opened a pull request:
https://github.com/apache/carbondata/pull/1722
[CARBONDATA-1755] Fixed bug occuring on current insert-overwrite and update
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed? No
- [x] Any backward compatibility impacted? No
- [x] Document update required? No
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SangeetaGulia/incubator-carbondata CARBONDATA-1755
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1722.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1722
----
commit c765ff3d8d33f70b433d6f97ea1cc02c6262b228
Author: SangeetaGulia <sa...@...>
Date: 2017-12-22T11:08:10Z
Fixed bug occuring on current insert-overwrite and update
----
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2647/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on current inse...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1722
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2549/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1339/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on current inse...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1722
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2539/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on current inse...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1081/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on current inse...
Posted by SangeetaGulia <gi...@git.apache.org>.
Github user SangeetaGulia commented on the issue:
https://github.com/apache/carbondata/pull/1722
retest sdv please.
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1722
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2595/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1168/
---
[GitHub] carbondata pull request #1722: [CARBONDATA-1755] Fixed bug occuring on concu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1722
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2571/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1138/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1415/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1722
LGTM
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1208/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2640/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1722
Please add testcase and add description of this PR
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by SangeetaGulia <gi...@git.apache.org>.
Github user SangeetaGulia commented on the issue:
https://github.com/apache/carbondata/pull/1722
retest this please
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2429/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:
https://github.com/apache/carbondata/pull/1722
retest this please
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2391/
---
[GitHub] carbondata pull request #1722: [CARBONDATA-1755] Fixed bug occuring on concu...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1722#discussion_r160079943
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ---
@@ -52,6 +53,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
return Seq.empty
}
val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
+ val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)
+ if (isLoadInProgress) {
+ LOGGER.error("Cannot run data loading and update on same table concurrently. Please wait"
+ + " for load to finish")
+ throw new Exception("Cannot run data loading and update on same table concurrently. " +
--- End diff --
Use the `ConcurrentOperationException` added in #1711
---
[GitHub] carbondata pull request #1722: [CARBONDATA-1755] Fixed bug occuring on concu...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1722#discussion_r158901669
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/TestInsertUpdateConcurrentTest.scala ---
@@ -0,0 +1,84 @@
+package org.apache.carbondata.spark.testsuite.iud
--- End diff --
Please add the apache license file header
---
[GitHub] carbondata pull request #1722: [CARBONDATA-1755] Fixed bug occuring on concu...
Posted by SangeetaGulia <gi...@git.apache.org>.
Github user SangeetaGulia commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1722#discussion_r160086580
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ---
@@ -52,6 +53,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
return Seq.empty
}
val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
+ val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)
+ if (isLoadInProgress) {
+ LOGGER.error("Cannot run data loading and update on same table concurrently. Please wait"
+ + " for load to finish")
+ throw new Exception("Cannot run data loading and update on same table concurrently. " +
--- End diff --
@jackylk I will update this code once #1711 will be merged.
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1722
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2569/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on current inse...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2297/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2354/
---
[GitHub] carbondata pull request #1722: [CARBONDATA-1755] Fixed bug occuring on concu...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1722#discussion_r160090617
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ---
@@ -52,6 +53,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
return Seq.empty
}
val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
+ val isLoadInProgress = SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)
+ if (isLoadInProgress) {
+ LOGGER.error("Cannot run data loading and update on same table concurrently. Please wait"
+ + " for load to finish")
+ throw new Exception("Cannot run data loading and update on same table concurrently. " +
--- End diff --
#1711 is merged
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1722
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2384/
---
[GitHub] carbondata issue #1722: [CARBONDATA-1755] Fixed bug occuring on concurrent i...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1722
retest this please
---