You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/20 04:23:44 UTC
[GitHub] [hudi] wangxianghu opened a new pull request #1993: [MINOR]Move HoodieUpgradeDowngradeException to exception package
wangxianghu opened a new pull request #1993:
URL: https://github.com/apache/hudi/pull/1993
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*Move HoodieUpgradeDowngradeException to exception package*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua merged pull request #1993: [MINOR] Move HoodieUpgradeDowngradeException to exception package
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1993:
URL: https://github.com/apache/hudi/pull/1993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a change in pull request #1993: [MINOR] Move HoodieUpgradeDowngradeException to exception package
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1993:
URL: https://github.com/apache/hudi/pull/1993#discussion_r473865745
##########
File path: hudi-client/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java
##########
@@ -27,6 +27,7 @@
import org.apache.hadoop.fs.FSDataOutputStream;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
+import org.apache.hudi.exception.HoodieUpgradeDowngradeException;
Review comment:
It would be better to add an empty line to split the different type of import statements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #1993: [MINOR]Move HoodieUpgradeDowngradeException to exception package
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1993:
URL: https://github.com/apache/hudi/pull/1993#issuecomment-677172386
@yanghua @nsivabalan please take a look when free
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on a change in pull request #1993: [MINOR] Move HoodieUpgradeDowngradeException to exception package
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #1993:
URL: https://github.com/apache/hudi/pull/1993#discussion_r473878261
##########
File path: hudi-client/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java
##########
@@ -27,6 +27,7 @@
import org.apache.hadoop.fs.FSDataOutputStream;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
+import org.apache.hudi.exception.HoodieUpgradeDowngradeException;
Review comment:
> It would be better to add an empty line to split the different type of import statements?
@yanghua thanks for your review. I moved it to be with other hudi import statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org