You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/09/02 16:09:32 UTC

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23364


Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................

KUDU-1261 add array.fbs into common/serdes

One of the previous changelists added Flatbuffers into the Kudu's
3rd-party, along with basic and benchmark tests.

This changelist adds a separate Flatbuffers IDL file array.fbs for
serdes-ing of Kudu 1D array types into the common/serdes directory.
The idea is to keep the earlier introduced (and almost identical as
of now) .fbs IDL file just for benchmarking, tests, and experiments,
so these two might evolve independently.

This is necessary for follow-up changelists.

Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
---
M src/kudu/common/CMakeLists.txt
A src/kudu/common/serdes/array1d.fbs
2 files changed, 71 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/23364/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 3:

Will this need followup changes to support decimal type?


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 23:26:12 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1742/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 21:09:57 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 04 Sep 2025 22:31:13 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 3:

> Will this need followup changes to support decimal type?

I'm not planning to support DECIMAL128 in this iteration at all.  Same for INT128.

As for DECIMAL32 and DECIMAL64, they are covered by UInt32 and UInt64.  If necessary, we can add corresponding shims on top of existing union descriptors.


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 23:29:20 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1742/


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:39:25 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1757/


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 23:17:27 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23364

to look at the new patch set (#4).

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................

KUDU-1261 add array.fbs into common/serdes

One of the previous changelists added Flatbuffers into the Kudu's
3rd-party, along with basic and benchmark tests.

This changelist adds a separate Flatbuffers IDL file array.fbs for
serdes-ing of Kudu 1D array types into the common/serdes directory.
The idea is to keep the earlier introduced (and almost identical as
of now) .fbs IDL file just for benchmarking, tests, and experiments,
so these two might evolve independently.

This is necessary for follow-up changelists.

Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
---
M src/kudu/common/CMakeLists.txt
A src/kudu/common/serdes/array1d.fbs
2 files changed, 72 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/23364/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1736/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 16:18:23 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 4: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1760/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Sep 2025 00:07:47 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 04 Sep 2025 21:24:36 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 3:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1751/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 16:12:41 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23364

to look at the new patch set (#3).

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................

KUDU-1261 add array.fbs into common/serdes

One of the previous changelists added Flatbuffers into the Kudu's
3rd-party, along with basic and benchmark tests.

This changelist adds a separate Flatbuffers IDL file array.fbs for
serdes-ing of Kudu 1D array types into the common/serdes directory.
The idea is to keep the earlier introduced (and almost identical as
of now) .fbs IDL file just for benchmarking, tests, and experiments,
so these two might evolve independently.

This is necessary for follow-up changelists.

Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
---
M src/kudu/common/CMakeLists.txt
A src/kudu/common/serdes/array1d.fbs
2 files changed, 75 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/23364/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1736/


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 16:09:41 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1760/


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 04 Sep 2025 22:07:28 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 3:

> > Will this need followup changes to support decimal type?
 > 
 > I'm not planning to support DECIMAL128 in this iteration at all. 
 > Same for INT128.
 > 
 > As for DECIMAL32 and DECIMAL64, they are covered by UInt32 and
 > UInt64.  If necessary, we can add corresponding shims on top of
 > existing union descriptors.

For more context, Flatbuffers is rather a transport layer, so there isn't a direct correspondence between Kudu types and corresponding Flatbuffer types if looking at the representation of the data in memory and on the wire.

As for INT128 and DECIMAL128 support, I think we can achieve it by either:
  * Patching Flatbuffers in Kudu's 3rd-party to natively support 16-byte integers, and adding corresponding shims in this .fbs file
  * Use the UInt64 to pass the data, interpreting 2 consecutive 64-bit numbers as parts of one 128 number.  That's uglier, but it should work.


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 23:40:02 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................

KUDU-1261 add array.fbs into common/serdes

One of the previous changelists added Flatbuffers into the Kudu's
3rd-party, along with basic and benchmark tests.

This changelist adds a separate Flatbuffers IDL file array.fbs for
serdes-ing of Kudu 1D array types into the common/serdes directory.
The idea is to keep the earlier introduced (and almost identical as
of now) .fbs IDL file just for benchmarking, tests, and experiments,
so these two might evolve independently.

This is necessary for follow-up changelists.

Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Reviewed-on: http://gerrit.cloudera.org:8080/23364
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/common/CMakeLists.txt
A src/kudu/common/serdes/array1d.fbs
2 files changed, 72 insertions(+), 1 deletion(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 4: Verified+1

unrelated test failures in Java tests (known flaky tests), kudu-admin-test


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Sep 2025 00:09:40 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1757/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 04 Sep 2025 01:14:23 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 add array.fbs into common/serdes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )

Change subject: KUDU-1261 add array.fbs into common/serdes
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1751/


-- 
To view, visit http://gerrit.cloudera.org:8080/23364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481
Gerrit-Change-Number: 23364
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 04:12:38 +0000
Gerrit-HasComments: No