You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/18 13:46:56 UTC
[GitHub] [pulsar] horsteff commented on a change in pull request #7533: [Issue 7492][pulsar-broker] Cleanup configuration process when using PulsarStandaloneBuilder
horsteff commented on a change in pull request #7533:
URL: https://github.com/apache/pulsar/pull/7533#discussion_r456791768
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
##########
@@ -97,10 +108,31 @@ public PulsarStandaloneBuilder withAdvertisedAddress(String advertisedAddress) {
return this;
}
- public PulsarStandalone build() {
- ServiceConfiguration config = new ServiceConfiguration();
- config.setClusterName("standalone");
- pulsarStandalone.setConfig(config);
+ public PulsarStandalone build()
+ {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org