You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/08/28 09:00:17 UTC
[PR] HDDS-11378. Allow disabling OM version-specific feature via config [ozone]
adoroszlai opened a new pull request, #7129:
URL: https://github.com/apache/ozone/pull/7129
## What changes were proposed in this pull request?
`OzoneManagerVersion` lets client know what kind of requests OM supports. The goal of this task is to allow disabling version-specific features in OM, even if it supports the feature according to versioning. This is achieved by a private config (not added to `ozone-default.xml`, nor any `@Config` objects).
The config itself is just a way to indicate that the feature is to be disabled. Actual restriction needs to be implemented for each feature where desired. As part of this task, it is implemented for the "atomic rewrite key" feature (added in HDDS-10656).
https://issues.apache.org/jira/browse/HDDS-11378
## How was this patch tested?
Added acceptance test case in `compatibility`, ran locally.
CI (pending):
https://github.com/adoroszlai/ozone/actions/runs/10593377482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11378. Allow disabling OM version-specific feature via config [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on PR #7129:
URL: https://github.com/apache/ozone/pull/7129#issuecomment-2314776472
Looking at the change, the feature is not disabled by default - Is that correct?
If so, that is the correct way to do this in my opinion. I believe we should NOT disable new features by default, otherwise people struggle to find and use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11378. Allow disabling OM version-specific feature via config [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7129:
URL: https://github.com/apache/ozone/pull/7129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11378. Allow disabling OM version-specific feature via config [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7129:
URL: https://github.com/apache/ozone/pull/7129#issuecomment-2314779837
> the feature is not disabled by default - Is that correct?
Correct, enabled by default (since config defaults to `""`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11378. Allow disabling OM version-specific feature via config [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7129:
URL: https://github.com/apache/ozone/pull/7129#issuecomment-2347934320
> I don't understand ..., it claims to be a general framework to disable OM features but it is actually just a feature flag for key rewrite.
You are right, the title should have been more specific (mentioning key rewrite).
> From the config perspective it is worse than a feature flag, because one needs to manually inspect the code to see if the feature they want to disable is even supported if they configure it.
It is intentionally undocumented, because the restriction is not implemented for other existing features.
> It seems this was done because there is a stigma around adding feature flags, but one had to be added so it was given a more generic name and implementation.
That impression is wrong. It was done this way to avoid the proliferation of config properties when a single config property is enough for the same. However, I do not have time to implement it for every other feature. Folks are free to use this to control the feature they work(ed) on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11378. Allow disabling OM version-specific feature via config [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7129:
URL: https://github.com/apache/ozone/pull/7129#issuecomment-2316815015
Thanks @sodonnel for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org