[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1284: [CELEBORN-350][FLINK]Add PluginConf to be compatible with old configur…

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #1284:
URL: https://github.com/apache/incubator-celeborn/pull/1284#discussion_r1119822614


##########
client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGateFactory.java:
##########
@@ -57,20 +59,23 @@ public class RemoteShuffleInputGateFactory {
   /** Sum of buffers. */
   private final int numBuffersPerGate;
 
-  public static final String MEMORY_PER_INPUT_GATE = "32m";
-  public static final String MIN_MEMORY_PER_GATE = "8m";
-  public static final int NUM_CONCURRENT_READINGS = Integer.MAX_VALUE;
   private CelebornConf celebornConf;
 
   public RemoteShuffleInputGateFactory(
-      CelebornConf conf, NetworkBufferPool networkBufferPool, int networkBufferSize) {
+      Configuration flinkConf,
+      CelebornConf conf,
+      NetworkBufferPool networkBufferPool,
+      int networkBufferSize) {
+    this.celebornConf = conf;
     long configuredMemorySize =
-        org.apache.celeborn.common.util.Utils.byteStringAsBytes(MEMORY_PER_INPUT_GATE);
+        org.apache.celeborn.common.util.Utils.byteStringAsBytes(
+            PluginConf.getValue(flinkConf, PluginConf.MEMORY_PER_INPUT_GATE));

Review Comment:
   suggest PluginConf support getStringValueAsBytes function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org