You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/06 17:52:23 UTC

[GitHub] [incubator-mxnet] roywei opened a new pull request #14346: [MXNet-1334][WIP][Fit API]base class for estimator and eventhandler

roywei opened a new pull request #14346: [MXNet-1334][WIP][Fit API]base class for estimator and eventhandler
URL: https://github.com/apache/incubator-mxnet/pull/14346
 
 
   ## Description ##
   This is the first PR for the Gluon Fit API proposed here:  [Gluon Fit API tech design](https://cwiki.apache.org/confluence/display/MXNET/Gluon+Fit+API+-+Tech+Design)
   
   It add base classes for estimator and eventhandlers, and an example.  We would like to merge into fit-api branch so other controbutors can work on top of it before making it available on master branch.
   
   JIRA epic can be found here: https://issues.apache.org/jira/browse/MXNET-1333
   We are separating this into a few PRs, all tracked by JIRA issues under the epic.
   
   We will open follow up PRs for the following tasks:
   1.  CNN and RNN examples using the fit API
   2. User experience improvement on initialization, context management, and hybridization
   3. More eventhandlers like Checkpoint, early stopping. 
   4. Multi output support for Multi-task and SSD use cases and examples
   5. Multi trainer support for encoder decoder and neural machine translation example.
   6. Unit tests and integration tests 
   7. Documentation 
   
   
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-1334](https://issues.apache.org/jira/browse/MXNET-1334) created
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   1. Base class for estimator with fit method
   2. Base class for event handlers
   3. simple cnn example on mnist dataset
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services