[GitHub] [hudi] xushiyan commented on a change in pull request #4125: [HUDI-2868] Fix org.apache.hudi.HoodieSparkSqlWriterSuite

[GitBox <gi...@apache.org>]

xushiyan commented on a change in pull request #4125:
URL: https://github.com/apache/hudi/pull/4125#discussion_r757727583



##########
File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala
##########
@@ -302,9 +306,10 @@ class HoodieSparkSqlWriterSuite {
       try {
         // write to Hudi
         HoodieSparkSqlWriter.write(sqlContext, SaveMode.Append, fooTableModifier, df)
-        Assertions.fail("Should have thrown exception")
+        fail("Should have thrown exception")
       } catch {
-        case e: HoodieException => assertTrue(e.getMessage.contains("hoodie.populate.meta.fields already disabled for the table. Can't be re-enabled back"))
+        case e: HoodieException => assertTrue(e.getMessage.startsWith("Config conflict"))

Review comment:
       @nsivabalan please note that conflict config like `populate MetaFields` will be captured in `org.apache.hudi.HoodieWriterUtils#validateTableConfig`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org