[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1931: IGNITE-19021 Support the directory deployment

["PakhomovAlexander (via GitHub)" <gi...@apache.org>]

PakhomovAlexander commented on code in PR #1931:
URL: https://github.com/apache/ignite-3/pull/1931#discussion_r1169576775


##########
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/key/UnitMetaSerializer.java:
##########
@@ -75,21 +69,45 @@ private static void appendWithEncoding(StringBuilder sb, String content) {
      */
     public static UnitMeta deserialize(byte[] bytes) {
         String s = new String(bytes, UTF_8);
-        String[] split = s.split(SEPARATOR);
+        String[] split = s.split(SEPARATOR, -1);
+
+        String id = decode(split[0]);
+        String version = decode(split[1]);
+        List<String> fileNames = deserializeList(split[2]);

Review Comment:
   Do we really need to store all file names in metastorage? Maybe it is enough to store only the base path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org