You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "bluewang (via GitHub)" <gi...@apache.org> on 2023/04/18 02:28:33 UTC
[GitHub] [inlong] bluewang opened a new pull request, #7872: [INLONG-7871][Dashboard] MySQL source supports filling in the database name whitelist
bluewang opened a new pull request, #7872:
URL: https://github.com/apache/inlong/pull/7872
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes https://github.com/apache/inlong/issues/7871
### Verifying this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] bluewang commented on a diff in pull request #7872: [INLONG-7871][Dashboard] MySQL source supports filling in the database name whitelist
Posted by "bluewang (via GitHub)" <gi...@apache.org>.
bluewang commented on code in PR #7872:
URL: https://github.com/apache/inlong/pull/7872#discussion_r1169636822
##########
inlong-dashboard/src/plugins/sources/defaults/MySQLBinlog.ts:
##########
@@ -145,4 +145,16 @@ export default class TubeMqSource
})
@I18n('meta.Sources.Db.TableWhiteList')
tableWhiteList: boolean;
+
+ @FieldDecorator({
+ type: 'input',
+ tooltip: i18n.t('meta.Sources.Db.DatabaseWhiteListHelp'),
+ rules: [{ required: true }],
Review Comment:
can be empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7872: [INLONG-7871][Dashboard] MySQL source supports filling in the database name whitelist
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7872:
URL: https://github.com/apache/inlong/pull/7872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #7872: [INLONG-7871][Dashboard] MySQL source supports filling in the database name whitelist
Posted by "leezng (via GitHub)" <gi...@apache.org>.
leezng commented on code in PR #7872:
URL: https://github.com/apache/inlong/pull/7872#discussion_r1169588430
##########
inlong-dashboard/src/plugins/sources/defaults/MySQLBinlog.ts:
##########
@@ -145,4 +145,16 @@ export default class TubeMqSource
})
@I18n('meta.Sources.Db.TableWhiteList')
tableWhiteList: boolean;
+
+ @FieldDecorator({
+ type: 'input',
+ tooltip: i18n.t('meta.Sources.Db.DatabaseWhiteListHelp'),
+ rules: [{ required: true }],
Review Comment:
Is it possible to leave it blank?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org