[GitHub] [ignite-3] zstan commented on a diff in pull request #2047: IGNITE-18831 Sql. Fix dynamic parameters type coercion.

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #2047:
URL: https://github.com/apache/ignite-3/pull/2047#discussion_r1198581363


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java:
##########
@@ -164,15 +166,30 @@ public void testWithDifferentParametersTypes() {
      */
     @Test
     public void testWithDifferentParametersTypesMismatch() {
-        assertThrows(CalciteContextException.class, () -> assertQuery("SELECT COALESCE(12.2, ?)").withParams("b").returns(12.2).check());
-        assertThrows(CalciteContextException.class, () -> assertQuery("SELECT COALESCE(?, ?)").withParams(12.2, "b").returns(12.2).check());
+        assertThrows(CalciteContextException.class, () -> assertQuery("SELECT COALESCE(12.2, ?)").withParams("b").check());

Review Comment:
   why we no more check return result ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org