[GitHub] spark pull request #17644: [SPARK-17729] [SQL] Enable creating hive bucketed...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17644#discussion_r114784136
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -632,9 +632,51 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
         val rawTable = getRawTable(db, table)
         val withNewSchema = rawTable.copy(schema = schema)
         verifyColumnNames(withNewSchema)
    +
    +    val newProperties = collection.mutable.Map[String, String]()
    +    for ((property, value) <- withNewSchema.properties) {
    +      newProperties.put(property, value)
    +    }
    +    for ((property, value) <- tableMetaToTableProps(withNewSchema)) {
    +      newProperties.put(property, value)
    +    }
    +
    +    // Since the table schema will be changed, check if the bucketing and sort columns are still
    --- End diff --
    
    I don't think we need to do this, according to the document of `ExternalCatalog.alterTableSchema`, the caller will guarantee that the new schema still contains partition columns and bucket columns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org