You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Vimal Sharma <vi...@hortonworks.com> on 2016/05/20 06:42:36 UTC
Review Request 47638: ATLAS-752 Column rename in Hive should retain
traits/tags associated with it
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-752
https://issues.apache.org/jira/browse/ATLAS-752
Repository: atlas
Description
-------
ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
Diff: https://reviews.apache.org/r/47638/diff/
Testing
-------
Thanks,
Vimal Sharma
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
> On May 20, 2016, 4:08 p.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, line 312
> > <https://reviews.apache.org/r/47638/diff/1/?file=1388845#file1388845line312>
> >
> > pls change var name from nameChanged to nameNotModified.
I changed the code to use Hashmaps and so this variable is not there in the code anymore. Please review the latest patch ATLAS-752-v2.patch.
- Vimal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134157
-----------------------------------------------------------
On May 20, 2016, 5:50 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 20, 2016, 5:50 p.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134157
-----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 311)
<https://reviews.apache.org/r/47638/#comment198814>
pls change var name from nameChanged to nameNotModified.
- Suma Shivaprasad
On May 20, 2016, 6:42 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 20, 2016, 6:42 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134143
-----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 326)
<https://reviews.apache.org/r/47638/#comment198811>
Instead of double loop twice, create maps for each and use maps
- Shwetha GS
On May 20, 2016, 6:42 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 20, 2016, 6:42 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
> On May 24, 2016, 7:18 p.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java, line 745
> > <https://reviews.apache.org/r/47638/diff/2/?file=1391380#file1391380line745>
> >
> > can you pls add a test with column position changed as well
I think we already have tests for column position change. Can you please look into the last three tests in testAlterTableChangeColumn in HiveHookIT
- Vimal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134617
-----------------------------------------------------------
On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 6:52 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134617
-----------------------------------------------------------
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java (line 742)
<https://reviews.apache.org/r/47638/#comment199461>
can you pls add a test with column position changed as well
- Suma Shivaprasad
On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 6:52 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Suma Shivaprasad <su...@gmail.com>.
> On May 26, 2016, 3:25 a.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, line 345
> > <https://reviews.apache.org/r/47638/diff/2-3/?file=1391379#file1391379line345>
> >
> > its better to load the newTable from metastore here instead of directly passing it. The reason is some flags and properties on the table are incorrect/incomplete when they are not reloaded from hive metastore? Any reason this was done?
>
> Vimal Sharma wrote:
> If we load newTable from Hive metaStore, it will end up creating a new entity for the table and all its columns. As a result, the traits associated with the column are lost and the test testTraitsPreservedOnColumnRename() fails.
Oh ok. I was a bit confused since we were passing in newTable to the function. If we intend to create the old state of table, then should we pass in oldTable(even though it is the same currently but if hive interface changes and starts passing new column state in newTable, there will be unexpected issues later on) or is there any issue with that?
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134911
-----------------------------------------------------------
On May 25, 2016, 6:41 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 6:41 p.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
> On May 26, 2016, 3:25 a.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, line 345
> > <https://reviews.apache.org/r/47638/diff/2-3/?file=1391379#file1391379line345>
> >
> > its better to load the newTable from metastore here instead of directly passing it. The reason is some flags and properties on the table are incorrect/incomplete when they are not reloaded from hive metastore? Any reason this was done?
If we load newTable from Hive metaStore, it will end up creating a new entity for the table and all its columns. As a result, the traits associated with the column are lost and the test testTraitsPreservedOnColumnRename() fails.
- Vimal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134911
-----------------------------------------------------------
On May 25, 2016, 6:41 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 6:41 p.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
> On May 26, 2016, 3:25 a.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, line 345
> > <https://reviews.apache.org/r/47638/diff/2-3/?file=1391379#file1391379line345>
> >
> > its better to load the newTable from metastore here instead of directly passing it. The reason is some flags and properties on the table are incorrect/incomplete when they are not reloaded from hive metastore? Any reason this was done?
>
> Vimal Sharma wrote:
> If we load newTable from Hive metaStore, it will end up creating a new entity for the table and all its columns. As a result, the traits associated with the column are lost and the test testTraitsPreservedOnColumnRename() fails.
>
> Suma Shivaprasad wrote:
> Oh ok. I was a bit confused since we were passing in newTable to the function. If we intend to create the old state of table, then should we pass in oldTable(even though it is the same currently but if hive interface changes and starts passing new column state in newTable, there will be unexpected issues later on) or is there any issue with that?
Passing oldTable makes sense considering hive interface might change and start passing new column state. Thanks for the observation Suma.
I have made the change in the latest patch.
- Vimal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134911
-----------------------------------------------------------
On May 26, 2016, 6:04 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 6:04 p.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134911
-----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 345)
<https://reviews.apache.org/r/47638/#comment199860>
its better to load the newTable from metastore here instead of directly passing it. The reason is some flags and properties on the table are incorrect/incomplete when they are not reloaded from hive metastore? Any reason this was done?
- Suma Shivaprasad
On May 25, 2016, 6:41 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 6:41 p.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review135160
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On May 26, 2016, 6:04 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 6:04 p.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/
-----------------------------------------------------------
(Updated May 26, 2016, 6:04 p.m.)
Review request for atlas and Shwetha GS.
Bugs: ATLAS-752
https://issues.apache.org/jira/browse/ATLAS-752
Repository: atlas
Description
-------
ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
Diff: https://reviews.apache.org/r/47638/diff/
Testing
-------
File Attachments
----------------
Revised Patch
https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
Thanks,
Vimal Sharma
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/
-----------------------------------------------------------
(Updated May 25, 2016, 6:41 p.m.)
Review request for atlas and Shwetha GS.
Changes
-------
Incorporated Suma's suggestions and added test for "alter table" queries for existing tables without Atlas Hive Hook
Bugs: ATLAS-752
https://issues.apache.org/jira/browse/ATLAS-752
Repository: atlas
Description
-------
ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
Diff: https://reviews.apache.org/r/47638/diff/
Testing
-------
File Attachments
----------------
Revised Patch
https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
Thanks,
Vimal Sharma
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
> On May 24, 2016, 7:16 p.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, line 382
> > <https://reviews.apache.org/r/47638/diff/2/?file=1391379#file1391379line382>
> >
> > Can we overload this function instead of making it null?
In all the calls to function createOrUpdateEntities, the last argument is null. Basically we don't need the changes made in this function.Does it make sense to revert the changes made to this function.
- Vimal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134616
-----------------------------------------------------------
On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 6:52 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134616
-----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 381)
<https://reviews.apache.org/r/47638/#comment199460>
Can we overload this function instead of making it null?
- Suma Shivaprasad
On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 6:52 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134618
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 6:52 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
>
> Diff: https://reviews.apache.org/r/47638/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Revised Patch
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/
-----------------------------------------------------------
(Updated May 23, 2016, 6:52 a.m.)
Review request for atlas and Shwetha GS.
Bugs: ATLAS-752
https://issues.apache.org/jira/browse/ATLAS-752
Repository: atlas
Description
-------
ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
Diff: https://reviews.apache.org/r/47638/diff/
Testing
-------
File Attachments
----------------
Revised Patch
https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
Thanks,
Vimal Sharma
Re: Review Request 47638: ATLAS-752 Column rename in Hive should
retain traits/tags associated with it
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/
-----------------------------------------------------------
(Updated May 20, 2016, 5:50 p.m.)
Review request for atlas and Shwetha GS.
Bugs: ATLAS-752
https://issues.apache.org/jira/browse/ATLAS-752
Repository: atlas
Description
-------
ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits should be retained with the new column
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
Diff: https://reviews.apache.org/r/47638/diff/
Testing
-------
File Attachments (updated)
----------------
Revised Patch
https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
Thanks,
Vimal Sharma