You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Gergely Pollak (JIRA)" <ji...@apache.org> on 2019/02/22 11:22:00 UTC
[jira] [Comment Edited] (YARN-9322) Store metrics for custom
resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo
[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774727#comment-16774727 ]
Gergely Pollak edited comment on YARN-9322 at 2/22/19 11:21 AM:
----------------------------------------------------------------
I'm always concerned when making visibility changes, because that means we may make breaking change in an internal API (obviously we don't break anything within hadoop project, but we might in other projects using our classes). So as a rule of thumb I think we should only change visibility when there is a good reason to. Also I see no harm in public getter methods, hiding certain setters might be a good practice, but I would recommend to hide only the newly added setters.
was (Author: shuzirra):
I'm always concerned when doing visibility changes, because that means we may make breaking change in an internal API (obviously we don't break anything within hadoop project, but we might in other projects using our classes). So as a rule of thumb I think we should only change visibility when there is a good reason to. Also I see no harm in public getter methods, hiding certain setters might be a good practice, but I would recommend to hide only the newly added setters.
> Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-9322
> URL: https://issues.apache.org/jira/browse/YARN-9322
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: Screen Shot 2019-02-21 at 12.06.46.png, YARN-9322.001.patch
>
>
> YARN-8842 implemented storing and exposing of metrics of custom resources.
> FSQueueMetrics should have a similar implementation.
> All metrics stored in this class should have their custom resource counterpart.
> In a consequence of metrics were not stored for custom resource type, FairSchedulerQueueInfo haven't contained those values therefore the UI v1 could not show them, obviously.
> See that gpu is missing from the value of "AM Max Resources" on the attached screenshot.
> Additionally, the callees of the following methods (in class FairSchedulerQueueInfo) should consider to query values for custom resource types too:
> getMaxAMShareMB
> getMaxAMShareVCores
> getAMResourceUsageMB
> getAMResourceUsageVCores
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org