[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #10706: [Bug] [Api] Not refresh workflow list when batch delete workflow failed

[GitBox <gi...@apache.org>]

Amy0104 commented on code in PR #10706:
URL: https://github.com/apache/dolphinscheduler/pull/10706#discussion_r934336070


##########
dolphinscheduler-ui/src/views/projects/workflow/definition/use-table.ts:
##########
@@ -257,6 +257,20 @@ export function useTable() {
         variables.page -= 1
       }
 
+      variables.checkedRowKeys = []
+      getTableData({
+        pageSize: variables.pageSize,
+        pageNo: variables.page,
+        searchVal: variables.searchVal
+      })
+    }).catch(() => {
+      if (
+          Math.ceil((variables.columns.length - variables.checkedRowKeys.length) / variables.pageSize) < variables.page
+          && variables.page > 1
+      ) {
+        variables.page -= 1;
+      }
+
       variables.checkedRowKeys = []

Review Comment:
   Columns length means how many columns that the data table has, and it does not seem to be related to how many workflows that the data table has. It is same as the 'checkedRowkeys'.  So I didn't get your point. The page number need to be reduced by one, only in this case that it is the last page with one workflow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org