[jira] Commented: (THRIFT-814) Include a TServlet in the standard Thrift distribution

["Mathias Herberts (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895818#action_12895818 ] 

Mathias Herberts commented on THRIFT-814:
-----------------------------------------

I removed the input/output transport factories, they were leftovers of the initial code I based this one on.

I also removed the finally clause which closed the transports, you are right the servlet container will take care of this (or not if keepalive was requested).

For your last point, I'm using a Collection of Map.Entry objects so I can have several times the same header. This would not be possible using a Map.

I'm attaching an updated version.

> Include a TServlet in the standard Thrift distribution
> ------------------------------------------------------
>
>                 Key: THRIFT-814
>                 URL: https://issues.apache.org/jira/browse/THRIFT-814
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (Java)
>    Affects Versions: 0.1, 0.2, 0.3
>         Environment: Any
>            Reporter: Mathias Herberts
>             Fix For: 0.4
>
>         Attachments: TServlet.java
>
>
> Thrift comes with a THttpClient used to consume Thrift services over an HTTP transport.
> Thrift however does not come with a Thrift specific servlet to serve those services.
> Tom White's servlet (http://www.lexemetech.com/2007/09/java-servlet-for-thrift.html, http://www.google.com/codesearch/p?hl=en&sa=N&cd=1&ct=rc#vusEaWnOsAk/thrift/TServlet.java&q=TServlet) is probably in wide use but it would be great to have a standard Thrift servlet everyone can build upon.
> I've adapted Tom's Servlet to allow for Processor/Protocol parameterization.
> I've not cleared the licensing issues though, as Tom's original work has no license associated with it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.