[GitHub] [iceberg] rdblue commented on a change in pull request #2705: Core: do not allow optional, double and float identifier fields

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2705:
URL: https://github.com/apache/iceberg/pull/2705#discussion_r653839023



##########
File path: core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java
##########
@@ -1342,18 +1348,18 @@ public void testSetIdentifierFieldsFails() {
             .setIdentifierFields("locations")
             .apply());
 
-    AssertHelpers.assertThrows("add a map key nested field should fail",
+    AssertHelpers.assertThrows("add an optional field should fail",
         IllegalArgumentException.class,
-        "must not be nested in " + SCHEMA.findField("locations"),
+        "not a required field",
         () -> new SchemaUpdate(SCHEMA, SCHEMA_LAST_COLUMN_ID)
-            .setIdentifierFields("locations.key.zip")
+            .setIdentifierFields("data")
             .apply());
 
-    AssertHelpers.assertThrows("add a map value nested field should fail",
+    AssertHelpers.assertThrows("add a map key nested field should fail",
         IllegalArgumentException.class,
         "must not be nested in " + SCHEMA.findField("locations"),
         () -> new SchemaUpdate(SCHEMA, SCHEMA_LAST_COLUMN_ID)
-            .setIdentifierFields("locations.value.lat")

Review comment:
       Was the test case using `locations.value.lat` removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org