[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #8203: Fix import dashboard id

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #8203: Fix import dashboard id
URL: https://github.com/apache/incubator-superset/pull/8203#discussion_r322336347
 
 

 ##########
 File path: superset/models/core.py
 ##########
 @@ -611,10 +611,11 @@ def alter_positions(dashboard, old_to_new_slc_id_dict):
 
         # override the dashboard
         existing_dashboard = None
+        remote_id = dashboard_to_import.params_dict.get("remote_id")
         for dash in session.query(Dashboard).all():
             if (
                 "remote_id" in dash.params_dict
-                and dash.params_dict["remote_id"] == dashboard_to_import.id
+                and dash.params_dict["remote_id"] == remote_id
 
 Review comment:
   it would be nice to add a unit test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org