You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "rkeen-siemens (via GitHub)" <gi...@apache.org> on 2023/05/24 15:56:07 UTC
[GitHub] [netbeans] rkeen-siemens opened a new issue, #5987: Modal dialog with wrong parent can lock up the application
rkeen-siemens opened a new issue, #5987:
URL: https://github.com/apache/netbeans/issues/5987
### Apache NetBeans version
Apache NetBeans 17
### What happened
`DialogDisplayerImpl.notify` sets the wrong parent when the currently active window is a modal dialog. When running with [FlatLaf providing window decorations](https://www.formdev.com/flatlaf/window-decorations/#enable_disable_linux) via `setDefaultLookAndFeelDecorated` on Linux, this allows the user to click the previously active modal dialog to bring it to the front due to [JDK-8306001](https://bugs.openjdk.org/browse/JDK-8306001).
### How to reproduce
Start a platform application with the following run before creating any UI (e.g. in an override of `ModuleInstall.validate`):
```java
JFrame.setDefaultLookAndFeelDecorated(true);
JDialog.setDefaultLookAndFeelDecorated(true);
```
Then from within an open model dialog invoke another using `DialogDisplayer.notify` and click the originally open dialog. This dialog will come to the front and if the new dialog is completely hidden there is nothing the user can do but kill the application.
### Did this work correctly in an earlier version?
No / Don't know
### Operating System
Linux
### JDK
JDK 17
### Apache NetBeans packaging
Apache NetBeans platform
### Anything else
_No response_
### Are you willing to submit a pull request?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rkeen-siemens commented on issue #5987: Modal dialog with wrong parent can lock up the application
Posted by "rkeen-siemens (via GitHub)" <gi...@apache.org>.
rkeen-siemens commented on issue #5987:
URL: https://github.com/apache/netbeans/issues/5987#issuecomment-1561951376
Thanks for pointing that out @neilcsmith-net, but the change to `DialogDisplayerImpl` was cosmetic and the same issue persists. I'll have a pull request with a fix soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net closed issue #5987: Modal dialog with wrong parent can lock up the application
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net closed issue #5987: Modal dialog with wrong parent can lock up the application
URL: https://github.com/apache/netbeans/issues/5987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #5987: Modal dialog with wrong parent can lock up the application
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on issue #5987:
URL: https://github.com/apache/netbeans/issues/5987#issuecomment-1561661321
Please check with NetBeans 18 - there have been some changes in this area eg. #5280 Be good to see if the issue is still relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #5987: Modal dialog with wrong parent can lock up the application
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on issue #5987:
URL: https://github.com/apache/netbeans/issues/5987#issuecomment-1562468458
Yes, the changes directly in `DialogDisplayerImpl` were cosmetic, but there were other changes recently in parenting logic that I thought might be relevant. They at least need to be consistent, and ideally in one place.
There's no need to open an issue if you have a PR ready anyway. Let's take the conversation there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists